Add a workaround for inner rects on transformed clips. #1820
Conversation
|
(Still needs a try run before merge) r? @kvark |
|
Servo / wrench tests pass. Gecko try looks ok, I think (two unexpected passes from the recent transform change, and two jobs that didn't start correct - re-running those now). https://hg.mozilla.org/try/rev/0a457dc9cac0a58e0cf922b8a61e5849b4b67066 |
| // Inner rects aren't valid if the item is not axis-aligned, which can | ||
| // be determined by the apply_rectangles field. This is mostly a band-aid | ||
| // until we have better handling of inner rectangles for transformed clips. | ||
| Some(ref inner) if !work_item.apply_rectangles && !inner.device_rect.is_empty() => { |
There was a problem hiding this comment.
weird, I believe they should be valid
|
I'm worried that band-aiding and working around the malfunctioning parts of WR in order to suffice the reftests would make us forget to actually make it work properly. We need to either create new bugs to keep track of it, leave |
|
@bors-servo r+ |
|
📌 Commit 75cd1f6 has been approved by |
Add a workaround for inner rects on transformed clips. Fixes #1814. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1820) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #1814.
This change is