-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Move to rust-url #1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
👍 |
Please consider upstreaming rust-url into the main Rust repo. |
@brson Yes, that’s planned as well, but I’d like to port Servo (which may requires some changes) and fix some bugs before that. After it’s in, upgrading it will be tied to upgrading the compiler. |
SimonSapin
added a commit
to SimonSapin/servo
that referenced
this issue
Jul 15, 2014
SimonSapin
added a commit
to SimonSapin/servo
that referenced
this issue
Jul 18, 2014
SimonSapin
added a commit
to SimonSapin/servo
that referenced
this issue
Jul 19, 2014
SimonSapin
added a commit
to SimonSapin/servo
that referenced
this issue
Jul 19, 2014
SimonSapin
added a commit
to SimonSapin/servo
that referenced
this issue
Jul 19, 2014
SimonSapin
added a commit
to SimonSapin/servo
that referenced
this issue
Jul 21, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I don’t think this is a priority right now, but I’d like to replace
extra::url
and our hacks inservo_util::url
with rust-url. This should fix #1671 and other corner cases. (See rust-lang/rust#10707)This depends (at least) on chris-morgan/rust-http#57.
It would also be a good time to revisit our handling of
file:
(#1094) anddata:
(#1268) URLs.In addition to URL parsing and resolving relative URLs against a base URL (which rust-url covers), one thing
servo_util::url
does is interpret some inputs as filenames relative to the current directory. This should be done only for the command-line arguments (eg. not for<a href>
), and can be achieved by passing afile:
URL for the current directory as the base URL. The URL standards is designed to handle this case. (Eg. by interpreting\
as/
and some special handling of stuff that looks like a Windows drive letter.)The text was updated successfully, but these errors were encountered: