Skip to content

Add HeapSizeOf impl for ParseError #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2017
Merged

Add HeapSizeOf impl for ParseError #370

merged 2 commits into from
Jun 25, 2017

Conversation

KiChjang
Copy link
Contributor

@KiChjang KiChjang commented Jun 25, 2017 •
edited by larsbergstrom
Loading

This change is Reviewable

@KiChjang KiChjang force-pushed the heapsizeof-parse-error branch from 74791c5 to 3d77bfb Compare June 25, 2017 04:52
@SimonSapin
Copy link
Member

  • Please use the known_heap_size! macro when possible
  • This does not compile. You need #[…] syntax to add an attribute to the next item, rather than #![…] which adds an attribute to the thing that contains such syntax.

@KiChjang KiChjang force-pushed the heapsizeof-parse-error branch from 3d77bfb to af16eef Compare June 25, 2017 07:15
@KiChjang
Copy link
Contributor Author

Ack, that was embarrassing. Fixed.

@KiChjang KiChjang force-pushed the heapsizeof-parse-error branch from af16eef to aea2ae2 Compare June 25, 2017 07:21
@SimonSapin
Copy link
Member

Thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit aea2ae2 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit aea2ae2 with merge dd068e5...

bors-servo pushed a commit that referenced this pull request Jun 25, 2017
Auto merge of #370 - KiChjang:heapsizeof-parse-error, r=SimonSapin
dd068e5 
Add HeapSizeOf impl for ParseError

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/370)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing dd068e5 to master...

@bors-servo bors-servo merged commit aea2ae2 into servo:master Jun 25, 2017
@KiChjang KiChjang deleted the heapsizeof-parse-error branch June 25, 2017 07:33
@KiChjang
Copy link
Contributor Author

Published this as 1.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KiChjang @SimonSapin @bors-servo