Fix building with current rust #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
&[T, ..n] isn't coerced to &[T] anymore, so we have to manually do that in a few places.
| None => if isindex { (&[], piece) } else { (piece, &[]) } | ||
| None => { | ||
| let tmp: (&[u8], &[u8]) = if isindex { (&[], piece) } else { (piece, &[]) }; | ||
| tmp |
There was a problem hiding this comment.
I think I’d prefer [].as_slice(). Does that work?
There was a problem hiding this comment.
No, the special rules for let foo = &rvalue expand the lifetime of the vector here. Those rules don't apply for [].as_slice() so you get a lifetime error.
There was a problem hiding this comment.
This is unfortunate, but oh well.
SimonSapin
added a commit
that referenced
this pull request
Aug 26, 2014
Fix building with current rust
|
Merged, thanks! |
|
D'oh, actually I'm an idiot. I'm at a different box now and didn't upgrade rustc yet. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&[T, ..n] isn't coerced to &[T] anymore, so we have to manually do that
in a few places.