This repository was archived by the owner on Nov 12, 2022. It is now read-only.
Remove FromJSValConvertible implementation for HandleValue #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
approved these changes
Dec 28, 2017
|
I'm going to hold off on merging this until the Servo PR is ready to merge. |
|
@bors-servo: r+ |
|
📌 Commit 2f473fa has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 3, 2018
Remove FromJSValConvertible implementation for HandleValue Needed for servo/servo#19644. Removes FromJSValConvertible implementations for `HandleValue`, so `Vec<HandleValue>` conversion is impossible. Also adds the implementation for `*mut JSObject` so the `sequence<object>` -> `CustomAutoRooterGuard<Vec<*mut JSObject>>` conversion works. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/388) <!-- Reviewable:end -->
|
@bors-servo: r- |
5 tasks
|
Bumped to 0.1.10. |
|
@bors-servo: r+ |
|
📌 Commit 81e042f has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 3, 2018
Remove FromJSValConvertible implementation for HandleValue Needed for servo/servo#19644. Removes FromJSValConvertible implementations for `HandleValue`, so `Vec<HandleValue>` conversion is impossible. Also adds the implementation for `*mut JSObject` so the `sequence<object>` -> `CustomAutoRooterGuard<Vec<*mut JSObject>>` conversion works. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/388) <!-- Reviewable:end -->
|
💔 Test failed - status-appveyor |
|
The appveyor problem will go away once #389 is merged. |
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 5, 2018
Remove FromJSValConvertible implementation for HandleValue Needed for servo/servo#19644. Removes FromJSValConvertible implementations for `HandleValue`, so `Vec<HandleValue>` conversion is impossible. Also adds the implementation for `*mut JSObject` so the `sequence<object>` -> `CustomAutoRooterGuard<Vec<*mut JSObject>>` conversion works. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/388) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for servo/servo#19644.
Removes FromJSValConvertible implementations for
HandleValue, soVec<HandleValue>conversion is impossible.Also adds the implementation for
*mut JSObjectso thesequence<object>->CustomAutoRooterGuard<Vec<*mut JSObject>>conversion works.This change is