Skip to content
This repository was archived by the owner on Jul 10, 2023. It is now read-only.

Bump foundation and graphics versions for #62. #68

Merged
merged 2 commits into from
Aug 2, 2017

Conversation

rthomas
Copy link
Contributor

@rthomas rthomas commented Aug 1, 2017

This removes the last of the compiler warnings.


This change is Reviewable

@rthomas
Copy link
Contributor Author

rthomas commented Aug 1, 2017

cc @jdm

@jdm
Copy link
Member

jdm commented Aug 1, 2017

This will need a version update as well.

@rthomas
Copy link
Contributor Author

rthomas commented Aug 1, 2017

Done.

@jdm
Copy link
Member

jdm commented Aug 1, 2017

@bors-servo: r+

@bors-servo
Copy link

📌 Commit ec06a98 has been approved by jdm

@bors-servo
Copy link

⌛ Testing commit ec06a98 with merge b9b466c...

bors-servo pushed a commit that referenced this pull request Aug 1, 2017
Bump foundation and graphics versions for #62.

This removes the last of the compiler warnings.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/68)
<!-- Reviewable:end -->
@bors-servo
Copy link

💥 Test timed out

@rthomas
Copy link
Contributor Author

rthomas commented Aug 2, 2017

Can the test be re-run - I'm not sure if the timeout is related to this PR.

@jdm
Copy link
Member

jdm commented Aug 2, 2017

@bors-servo: retry

@bors-servo
Copy link

⌛ Testing commit ec06a98 with merge 40193be...

bors-servo pushed a commit that referenced this pull request Aug 2, 2017
Bump foundation and graphics versions for #62.

This removes the last of the compiler warnings.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/68)
<!-- Reviewable:end -->
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: jdm
Pushing 40193be to master...

@bors-servo bors-servo merged commit ec06a98 into servo:master Aug 2, 2017
@nox
Copy link
Contributor

nox commented Aug 21, 2017

This was a breaking change… Please release 6.1.2 with the dependencies' bumps reverted, yank 6.1.1, and release 7.0.0 with the dependencies bumps back.

@rthomas
Copy link
Contributor Author

rthomas commented Aug 22, 2017

Will do, I don't have release permissions but will send the PRs.

@rthomas rthomas deleted the 62-version branch August 22, 2017 19:39
@jdm
Copy link
Member

jdm commented Aug 22, 2017

I already did this. Thanks anyways!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants