This repository was archived by the owner on Jul 10, 2023. It is now read-only.
Remove warnings for zero-sized structs #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the servo pattern mentioned in rust-lang/rust#27303 to replace the zero-sized structs with an `enum`.
Changes zero-sized structs to an `enum` and removed unused macro use statement.
|
I've left them as two commits, one to fix the issue with servo/core-text-rs#62 and the other to remove the warnings that I can. Let me know if you'd like me to squash them. |
|
Want to increase the version number in Cargo.toml so we can publish after merging? |
|
I've bumped the version number. |
jdm
reviewed
Jul 27, 2017
Cargo.toml
Outdated
| @@ -13,5 +13,5 @@ elcapitan = [] | |||
|
|
|||
| [dependencies] | |||
| bitflags = "0.9" | |||
| core-foundation = "0.4" | |||
| core-foundation = { path = "../core-foundation-rs/core-foundation" } #"0.4" | |||
There was a problem hiding this comment.
This change will need to be reverted.
There was a problem hiding this comment.
Ah yes ack, from my testing.
|
Sorry about that - Done. |
|
@bors-servo: r+ |
|
📌 Commit 4e29474 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 27, 2017
Remove warnings for zero-sized structs This change removes a bunch of warnings from the crate. The only remaining warnings are due to the bitflags macro usage. This will help fix servo/core-text-rs#62 when it upgrades to `core-graphics = 0.9`. @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/90) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes a bunch of warnings from the crate.
The only remaining warnings are due to the bitflags macro usage.
This will help fix servo/core-text-rs#62 when it upgrades to
core-graphics = 0.9.@jdm
This change is