Skip to content

Fix port schema #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix port schema #924

merged 1 commit into from
Jul 17, 2024

Conversation

matthias-pichler
Copy link
Collaborator

@matthias-pichler matthias-pichler commented Jul 17, 2024 •
edited
Loading

Signed-off-by: Matthias Pichler [email protected]

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

What this PR does:

the schema for port was using min and max for the range instead of the correct minimum and maximum.

flowDirective also had an extra additionalProperties which is invalid for strings

Additional information:

@matthias-pichler
fix: update invalid properties
abdd573 
Signed-off-by: Matthias Pichler <[email protected]>
cdavernas
cdavernas approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once again, great catch! Thank you so much for your awesome contributions!

@cdavernas
Copy link
Member

I guess you meant additionalProperties instead of unevaluatedProperties ;)

@cdavernas cdavernas merged commit e7dec69 into serverlessworkflow:main Jul 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@cdavernas cdavernas cdavernas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthias-pichler @cdavernas @ricardozanini