Skip to content

Adding titles to oneOf and repeating names #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fjtirado
Copy link
Collaborator

This will make POJO generators life easier when choosing a name for the POJO

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

What this PR does:

Additional information:

@fjtirado fjtirado force-pushed the Adding_titles_for_generators branch 3 times, most recently from 31e495a to e81aa69 Compare June 24, 2024 11:34
This will make POJO generators life easier when choosing a name for the
POJO

Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
@fjtirado fjtirado force-pushed the Adding_titles_for_generators branch from e81aa69 to 72508bb Compare June 24, 2024 11:48
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the awesome work!

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ricardozanini ricardozanini merged commit 2f00a62 into serverlessworkflow:main Jun 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants