-
Notifications
You must be signed in to change notification settings - Fork 159
[Fix_#873] Rename output.from and output.to #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
output.from is renamed as output.as output.to is renamed as export.as Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
40661e1
to
0d0357c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you feel export/to
would be better than export/as
, knowing it actuals transforms the context data?
Other than that, I'd rephrase some descriptions to make it more agnostic and a bit less technical.
For me |
Allright! @fjtirado ? |
@cdavernas @JBBianchi @fjtirado given the context, I also believe |
2v2 draw for |
I'll quickly catch up on the discussion and then get back to you |
01a2d7e
to
b4b7875
Compare
Ok so I have no strong opinions here. I agree with
that therefore I think export:
schema: {}
as: "..."
output:
schema: {}
as: "..." is my (only slightly) preferred option |
| Property | Type | Required | Description | | ||
|----------|:----:|:--------:|-------------| | ||
| schema | [`schema`](#schema) | `no` | The [`schema`](#schema) used to describe and validate context.<br>*Included to handle the non frequent case in which the context has a known format.* | | ||
| as | `string`<br>`object` | `no` | A runtime expression, if any, used to export the output data to the context. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link is missing on runtime expression
-> [runtime expression](#runtime-expressions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that particular link is missed everywhere, maybe should be fixed with a different PR?
Consensus reached! We keep things as @fjtirado commited them! Cheers everyone! |
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]> Update dsl-reference.md Co-authored-by: Ricardo Zanini <[email protected]> Update dsl-reference.md Co-authored-by: Ricardo Zanini <[email protected]> [Fix_#873] JpBianchi comments [Fix_#873] Ricardos comments Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks! ❤️
Sorry for late review though, forgot about this one 👅
fix(Sdk): Updated both InputDataModelDefinition and OutputDataModelDefinition to reflect serverlessworkflow/specification#892 fix(Sdk): Added the ExportDataModelDefinition, and updated TaskDefinition accordingly, to reflect serverlessworkflow/specification#892 Signed-off-by: Charles d'Avernas <[email protected]>
Fix #873
output.from is renamed as output.as
output.to is renamed as export.as
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does:
Additional information: