-
Notifications
You must be signed in to change notification settings - Fork 159
Fix usage of endpoint in-call http tasks #877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix usage of endpoint in-call http tasks #877
Conversation
Signed-off-by: Matthias Pichler <[email protected]>
Signed-off-by: Matthias Pichler <[email protected]>
3249ba3
to
a07afc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Cheers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be a PITA, but can you add an example? I think ours only has this structure:
endpoint:
uri: ...
Signed-off-by: Matthias Pichler <[email protected]>
no worries ... added an example 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in this case the format is uri-template
since we want to support dynamic calls within the task.
Signed-off-by: Matthias Pichler <[email protected]>
Signed-off-by: Matthias Pichler [email protected]
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does:
The DSL describes the callHttp endpoint property as:
However:
uri
field directly in call http tasksso I fixed both
Additional information: