-
Notifications
You must be signed in to change notification settings - Fork 160
Imports Validation Schemas into the Examples README during CI #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imports Validation Schemas into the Examples README during CI #803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Many thanks ❤️
I forgot to signoff my commits... If necessary, I created an other branch with a signed off commit. I can close this PR and open a new one if it's a big no go. |
@JBBianchi I think you can amend your commit and add the |
}, | ||
"keywords": ["cncf", "serverless", "workflow", "specification"], | ||
"author": "CNCF Serverless Workflow Specification", | ||
"license": "ISC", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which license is this? Can we change it to Apache?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, it's the default when generating the npm project I think. As far as I recall, I copy/pasted from https://github.com/serverlessworkflow/specification/blob/main/.ci/validation/package.json
@JBBianchi let's discuss tomorrow about the planning and the steps to install the bot! We might do it tomorrow during the meeting if necessary: #804 |
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
changed examples README CI actor Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Fix the Weekly Meetings anchor
I just did but I think I messed up ^^' I'll just close and open a new PR, it feels safer. |
Closed because of messy commit history, see #805 instead.