Skip to content

Imports Validation Schemas into the Examples README during CI #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Imports Validation Schemas into the Examples README during CI #803

wants to merge 4 commits into from

Conversation

JBBianchi
Copy link
Member

@JBBianchi JBBianchi commented Dec 13, 2023

Closed because of messy commit history, see #805 instead.

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many thanks ❤️

@JBBianchi
Copy link
Member Author

I forgot to signoff my commits... If necessary, I created an other branch with a signed off commit. I can close this PR and open a new one if it's a big no go.

@cdavernas @ricardozanini @tsurdilo @antmendoza WDYT ?

@ricardozanini
Copy link
Member

@JBBianchi I think you can amend your commit and add the -s :D

},
"keywords": ["cncf", "serverless", "workflow", "specification"],
"author": "CNCF Serverless Workflow Specification",
"license": "ISC",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which license is this? Can we change it to Apache?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it's the default when generating the npm project I think. As far as I recall, I copy/pasted from https://github.com/serverlessworkflow/specification/blob/main/.ci/validation/package.json

@ricardozanini
Copy link
Member

@JBBianchi let's discuss tomorrow about the planning and the steps to install the bot! We might do it tomorrow during the meeting if necessary: #804

JBBianchi and others added 4 commits December 14, 2023 10:55
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
changed examples README CI actor

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Fix the Weekly Meetings anchor
@JBBianchi
Copy link
Member Author

@JBBianchi I think you can amend your commit and add the -s :D

I just did but I think I messed up ^^'

I'll just close and open a new PR, it feels safer.

@JBBianchi JBBianchi closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants