Skip to content

rename workflowextensions.json to extensions.json #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

antmendoza
Copy link
Contributor

@antmendoza antmendoza commented Jun 18, 2023

Many thanks for submitting your Pull Request ❤️!

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Roadmap
  • Use Cases
  • Community
  • TCK
  • Other

Discussion or Issue link:

What this PR does / why we need it:

Special notes for reviewers:

Additional information:

Signed-off-by: Antonio Mendoza Pérez <[email protected]>
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why that PR? I know it's minor, but there is no discussion/issue or even proper description. Is there a problem with the file name as is?

@tsurdilo
Copy link
Contributor

my understanding is that we are trying to fix the editor on website cause its broken. im sure antonio will add a desription..

@cdavernas
Copy link
Member

cdavernas commented Jun 19, 2023

Allright, cheers! Btw, shouldn't we instead fix the website so that we can keep the orignal file name?
Again, no biggies, but extensions.json is less verbose and follows naming conventions of all files.
Or is that fix "temporary", meaning for current version only?

@antmendoza
Copy link
Contributor Author

@cdavernas appologies,

Shouldn't the id value be the same as the filename?

@antmendoza
Copy link
Contributor Author

@cdavernas extensions.json make sense to me

@cdavernas
Copy link
Member

@antmendoza ahah no worries, even less coming from you ❤️

@antmendoza
Copy link
Contributor Author

ok, I am renaming the filename, I will wait for @tsurdilo and @ricardozanini confirmation.

@ricardozanini
Copy link
Member

+1 to keep extensions.json.

@antmendoza antmendoza changed the title fix workflowextensions.json id rename workflowextensions.json to extensions.json Jun 19, 2023
@antmendoza
Copy link
Contributor Author

done :)

@antmendoza antmendoza requested review from cdavernas and tsurdilo June 19, 2023 23:31
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@antmendoza antmendoza merged commit 1f9e0d1 into serverlessworkflow:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants