-
Notifications
You must be signed in to change notification settings - Fork 159
rename workflowextensions.json to extensions.json #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename workflowextensions.json to extensions.json #774
Conversation
Signed-off-by: Antonio Mendoza Pérez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why that PR? I know it's minor, but there is no discussion/issue or even proper description. Is there a problem with the file name as is?
my understanding is that we are trying to fix the editor on website cause its broken. im sure antonio will add a desription.. |
Allright, cheers! Btw, shouldn't we instead fix the website so that we can keep the orignal file name? |
@cdavernas appologies, Shouldn't the id value be the same as the filename? |
@cdavernas |
@antmendoza ahah no worries, even less coming from you ❤️ |
ok, I am renaming the filename, I will wait for @tsurdilo and @ricardozanini confirmation. |
+1 to keep |
Signed-off-by: Antonio Mendoza Pérez <[email protected]>
done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Many thanks for submitting your Pull Request ❤️!
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does / why we need it:
Special notes for reviewers:
Additional information: