Skip to content

feat(*): add multi retry strategy #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(*): add multi retry strategy #700

wants to merge 1 commit into from

Conversation

lsytj0413
Copy link
Contributor

Signed-off-by: lsytj0413 [email protected]

Many thanks for submitting your Pull Request ❤️!

Please specify parts of this PR update:

  • Specification

Discussion or Issue link:

What this PR does / why we need it:

Add multi retry strategy to an action.

Special notes for reviewers:

Additional information:

Fixed #681

@tsurdilo
Copy link
Contributor

Thanks for the PR! Think we need little time to think about this. Personally must say I'm not a big fan of per-error retry policies. I think its confusing as it makes it impossible to figure out when next retry is going to happen. Also imo very hard to implement and third its quite confusing. I'd really like to see some real life use cases where this is needed.

@tsurdilo tsurdilo added the change: feature New feature or request. Impacts in a minor version change label Oct 26, 2022
@tsurdilo tsurdilo added this to the v0.9 milestone Oct 26, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@lsytj0413
Copy link
Contributor Author

/remove-stale

@github-actions github-actions bot removed the Stale PR label Dec 12, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@cdavernas
Copy link
Member

@lsytj0413 First of all, many thanks for your PR!

Second, I added the blocked label to this PR as of now, because of pending discussions regarding the v0.9 backlog, which might include #772. If so, current PR would be obsolete.

Please feel free to contribute, here or on referenced issue.

@lsytj0413 lsytj0413 closed this by deleting the head repository Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change: feature New feature or request. Impacts in a minor version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multi retryRef to action
4 participants