Fix the description of flow directives and addressed few issues in dsl and dsl-reference #1083

geomagilles · 2025-02-18T18:27:25Z

Please specify parts of this PR update:

Discussion or Issue link:
https://cloud-native.slack.com/archives/CMBAZQSEP/p1739812901298019
https://cloud-native.slack.com/archives/CMBAZQSEP/p1739085346279299

What this PR does:
Fix a few issues with the docs

Additional information:

dsl-reference.md

ricardozanini

Hi @geomagilles!

Can you please consider:

Remove the .DS_Store file, and add it to the root .gitignore file
Remove the added tabs to the tables

Thanks!

cdavernas

LGTM, aside from a couple of changes, space and tabs related

geomagilles · 2025-02-21T09:41:42Z

Done - I also slightly changed the description of the "exit" flow directive

cdavernas

Looks good to me! Thanks @geomagilles ❤️

cdavernas · 2025-02-21T20:45:55Z

@geomagilles Could you please sign-off your last commits?

serverlessworkflow#1082) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multiple YAML files Signed-off-by: Gilles Barbier <[email protected]> * fix(contributing): reverting pre-release versioning format Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]>

Signed-off-by: Gilles Barbier <[email protected]>

…tion into fixDocs

Signed-off-by: Gilles Barbier <[email protected]>

…tion into fixDocs

geomagilles · 2025-02-22T09:55:11Z

it should be good - sorry I'm not used to signed commits and now they are messy - you should do a 'squash merge'

cdavernas · 2025-02-22T10:03:31Z

Thanks @geomagilles! Unhappily, the DS_Store file has been included again 😞

Signed-off-by: Gilles Barbier <[email protected]>

…l and dsl-reference (serverlessworkflow#1083) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multip… (serverlessworkflow#1082) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multiple YAML files Signed-off-by: Gilles Barbier <[email protected]> * fix(contributing): reverting pre-release versioning format Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl): fix a few issues in dsl and dsl-reference Signed-off-by: Gilles Barbier <[email protected]> * update .gitignore to include .DS_Store Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): correct table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl): fix a few issues in dsl and dsl-reference Signed-off-by: Gilles Barbier <[email protected]> * update .gitignore to include .DS_Store Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): correct table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * remove again .DS_Store Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

* Fix #1076 - Make detail and title a runtime expression in the schema Signed-off-by: Ricardo Zanini <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Add string as anyOf Signed-off-by: Ricardo Zanini <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * feat(schema): allow expressions in HTTP query and headers (#1080) Issue #1079 Signed-off-by: Alexandru Georoceanu <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multip… (#1082) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multiple YAML files Signed-off-by: Gilles Barbier <[email protected]> * fix(contributing): reverting pre-release versioning format Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Fix the description of flow directives and addressed few issues in dsl and dsl-reference (#1083) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multip… (#1082) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multiple YAML files Signed-off-by: Gilles Barbier <[email protected]> * fix(contributing): reverting pre-release versioning format Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl): fix a few issues in dsl and dsl-reference Signed-off-by: Gilles Barbier <[email protected]> * update .gitignore to include .DS_Store Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): correct table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl): fix a few issues in dsl and dsl-reference Signed-off-by: Gilles Barbier <[email protected]> * update .gitignore to include .DS_Store Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): correct table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * remove again .DS_Store Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Fix broken link in README.md (#1084) Signed-off-by: Michal Broz <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Set task to support direct runtime expression Signed-off-by: Nyamath Shaik <[email protected]> * updated workflow schema along with table fix Signed-off-by: Nyamath Shaik <[email protected]> * updating the schema Signed-off-by: Nyamath Shaik <[email protected]> * addressing PR comment reviews Signed-off-by: Nyamath Shaik <[email protected]> * removing unwanted set example Signed-off-by: Nyamath Shaik <[email protected]> * Update dsl-reference.md Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Update dsl-reference.md Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Update dsl-reference.md Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * reverting back original set example change Signed-off-by: Nyamath Shaik <[email protected]> * Update dsl-reference.md Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * passing the set example as object Signed-off-by: Nyamath Shaik <[email protected]> * reverting to original Signed-off-by: Nyamath Shaik <[email protected]> * Add a new file that compares the Serverless Workflow to other popular DSLs Signed-off-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> * Fix a the `catalog` link in the `use` section table (#1088) Signed-off-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]> Signed-off-by: Alexandru Georoceanu <[email protected]> Signed-off-by: Gilles Barbier <[email protected]> Signed-off-by: Michal Broz <[email protected]> Signed-off-by: Charles d'Avernas <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]> Co-authored-by: Alexandru Georoceanu <[email protected]> Co-authored-by: Gilles Barbier <[email protected]> Co-authored-by: mbroz2 <[email protected]> Co-authored-by: Charles d'Avernas <[email protected]>

geomagilles requested review from ricardozanini and cdavernas as code owners February 18, 2025 18:27

ricardozanini approved these changes Feb 18, 2025

View reviewed changes

cdavernas reviewed Feb 20, 2025

View reviewed changes

dsl-reference.md Outdated Show resolved Hide resolved

cdavernas reviewed Feb 20, 2025

View reviewed changes

dsl-reference.md Outdated Show resolved Hide resolved

ricardozanini requested changes Feb 20, 2025

View reviewed changes

cdavernas requested changes Feb 20, 2025

View reviewed changes

geomagilles requested a review from cdavernas February 21, 2025 09:43

cdavernas approved these changes Feb 21, 2025

View reviewed changes

cdavernas changed the title ~~fix(dsl): fix a few issues in dsl and dsl-reference~~ Fix a few issues in dsl and dsl-reference Feb 21, 2025

cdavernas changed the title ~~Fix a few issues in dsl and dsl-reference~~ Fix tge description of flow directives and made a few issues in dsl and dsl-reference Feb 21, 2025

cdavernas changed the title ~~Fix tge description of flow directives and made a few issues in dsl and dsl-reference~~ Fix the description of flow directives and made a few issues in dsl and dsl-reference Feb 21, 2025

cdavernas changed the title ~~Fix the description of flow directives and made a few issues in dsl and dsl-reference~~ Fix the description of flow directives and addressed few issues in dsl and dsl-reference Feb 21, 2025

geomagilles added 7 commits February 22, 2025 10:31

fix(dsl): fix a few issues in dsl and dsl-reference

4792802

Signed-off-by: Gilles Barbier <[email protected]>

update .gitignore to include .DS_Store

98bf5b6

Signed-off-by: Gilles Barbier <[email protected]>

fix(dsl-reference): correct table formatting

cb26353

Signed-off-by: Gilles Barbier <[email protected]>

fix(dsl-reference): clarify flow directive descriptions

59b4c35

Signed-off-by: Gilles Barbier <[email protected]>

fix(dsl-reference): improve table formatting

7bf1279

Signed-off-by: Gilles Barbier <[email protected]>

fix(dsl-reference): clarify flow directive descriptions

5e2db39

Signed-off-by: Gilles Barbier <[email protected]>

geomagilles force-pushed the fixDocs branch from fef1630 to 5e2db39 Compare February 22, 2025 09:36

geomagilles added 6 commits February 22, 2025 10:39

fix(dsl): fix a few issues in dsl and dsl-reference

573baee

Signed-off-by: Gilles Barbier <[email protected]>

update .gitignore to include .DS_Store

e1828df

Signed-off-by: Gilles Barbier <[email protected]>

fix(dsl-reference): correct table formatting

084bd91

Signed-off-by: Gilles Barbier <[email protected]>

fix(dsl-reference): clarify flow directive descriptions

69d5263

Signed-off-by: Gilles Barbier <[email protected]>

fix(dsl-reference): improve table formatting

2a9b0d2

Signed-off-by: Gilles Barbier <[email protected]>

fix(dsl-reference): clarify flow directive descriptions

4cb5996

Signed-off-by: Gilles Barbier <[email protected]>

geomagilles force-pushed the fixDocs branch from 5e2db39 to 4cb5996 Compare February 22, 2025 09:39

geomagilles added 4 commits February 22, 2025 10:43

fix(dsl-reference): improve table formatting

0d2006b

Signed-off-by: Gilles Barbier <[email protected]>

Merge branch 'fixDocs' of github.com:geomagilles/serverless-specifica…

ff0c668

…tion into fixDocs

fix(dsl-reference): improve table formatting

d8384d7

Signed-off-by: Gilles Barbier <[email protected]>

Merge branch 'fixDocs' of github.com:geomagilles/serverless-specifica…

8188a39

…tion into fixDocs

geomagilles requested a review from ricardozanini February 22, 2025 09:53

remove again .DS_Store

0736f62

Signed-off-by: Gilles Barbier <[email protected]>

ricardozanini approved these changes Feb 24, 2025

View reviewed changes

ricardozanini merged commit a4fa9ca into serverlessworkflow:main Feb 24, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the description of flow directives and addressed few issues in dsl and dsl-reference #1083

Fix the description of flow directives and addressed few issues in dsl and dsl-reference #1083

geomagilles commented Feb 18, 2025

ricardozanini left a comment

cdavernas left a comment

geomagilles commented Feb 21, 2025

cdavernas left a comment

cdavernas commented Feb 21, 2025

geomagilles commented Feb 22, 2025 •

edited

Loading

cdavernas commented Feb 22, 2025

Fix the description of flow directives and addressed few issues in dsl and dsl-reference #1083

Fix the description of flow directives and addressed few issues in dsl and dsl-reference #1083

Conversation

geomagilles commented Feb 18, 2025

ricardozanini left a comment

Choose a reason for hiding this comment

cdavernas left a comment

Choose a reason for hiding this comment

geomagilles commented Feb 21, 2025

cdavernas left a comment

Choose a reason for hiding this comment

cdavernas commented Feb 21, 2025

geomagilles commented Feb 22, 2025 • edited Loading

cdavernas commented Feb 22, 2025

geomagilles commented Feb 22, 2025 •

edited

Loading