Skip to content

Add warnings about using the $secrets runtime expression #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cdavernas
Copy link
Member

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:
#979

What this PR does:

  • Adds warnings about using the $secrets runtime expression

Additional information:
This PR comes as a consensual, impactless fix to #979, which proposed (breaking) changes which were deemed unnecessary and potentially harmful.

@cdavernas cdavernas added change: documentation Improvements or additions to documentation. It won't impact a version change. area: spec Changes in the Specification labels Jan 9, 2025
@cdavernas cdavernas added this to the v1.0.0 milestone Jan 9, 2025
@cdavernas cdavernas self-assigned this Jan 9, 2025
@cdavernas cdavernas linked an issue Jan 9, 2025 that may be closed by this pull request
@ricardozanini ricardozanini merged commit e7a4460 into serverlessworkflow:main Jan 9, 2025
3 checks passed
@cdavernas cdavernas deleted the feat-warn-about-secrets-use branch January 9, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Properly decide on availability of $secrets argument
2 participants