-
Notifications
You must be signed in to change notification settings - Fork 159
Web Editor doesn't generate the diagram for my specific workflow #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hbelmiro opened this issue
Feb 1, 2022
· 4 comments
· Fixed by serverlessworkflow/sdk-typescript#164 or serverlessworkflow/serverlessworkflow.github.io#147
Closed
Web Editor doesn't generate the diagram for my specific workflow #587
hbelmiro opened this issue
Feb 1, 2022
· 4 comments
· Fixed by serverlessworkflow/sdk-typescript#164 or serverlessworkflow/serverlessworkflow.github.io#147
Comments
thank you! I am going to have a look |
antmendoza
pushed a commit
to antmendoza/serverlessworkflow_sdk-typescript
that referenced
this issue
Feb 1, 2022
Signed-off-by: Antonio Mendoza Pérez <[email protected]>
antmendoza
pushed a commit
to antmendoza/serverlessworkflow.github.io
that referenced
this issue
Feb 1, 2022
Signed-off-by: Antonio Mendoza Pérez <[email protected]>
tsurdilo
added a commit
to serverlessworkflow/sdk-typescript
that referenced
this issue
Feb 2, 2022
fix diagram generation serverlessworkflow/specification#587
@antmendoza thanks bro!!! @hbelmiro try again, Antonios prs are merged now. |
It works now 🎉 |
@hbelmiro Antonio did all the work :) But just fyi, you don't have to set "terminate": true on end definition in SW unless you have "keepActive" top-level prop set to true. Glad tho you did it so we could uncover the issue. |
antmendoza
added a commit
to serverlessworkflow/sdk-typescript
that referenced
this issue
Apr 18, 2022
commit 17fad27 Merge: 6d4dfb5 0cf8067 Author: Tihomir Surdilovic <[email protected]> Date: Tue Feb 1 20:52:32 2022 -0500 Merge pull request #164 from antmendoza/fix-diagram-generation fix diagram generation serverlessworkflow/specification#587 commit 0cf8067 Author: Antonio Mendoza Pérez <[email protected]> Date: Tue Feb 1 22:54:21 2022 +0100 fix diagram generation serverlessworkflow/specification#587 Signed-off-by: Antonio Mendoza Pérez <[email protected]> commit 6d4dfb5 Author: Antonio Mendoza Pérez <[email protected]> Date: Tue Jan 11 08:18:08 2022 +0100 Fix workflow validator (#163) fix WorkflowValidator commit 2636805 Author: Antonio Mendoza Pérez <[email protected]> Date: Mon Jan 10 21:46:11 2022 +0100 ignore js files in test phase (#162) commit b335771 Author: Antonio Mendoza Pérez <[email protected]> Date: Mon Jan 10 21:39:13 2022 +0100 Handle compensatedBy in diagram generation (#161) handle compensatedBy diagram generation commit a89acd0 Author: Antonio Mendoza Pérez <[email protected]> Date: Tue Dec 28 14:41:38 2021 +0100 Code formatting (#160) * order-properties-on-serialization Signed-off-by: Antonio Mendoza Pérez <[email protected]> * code-formating Signed-off-by: Antonio Mendoza Pérez <[email protected]> commit 219768d Author: Antonio Mendoza Pérez <[email protected]> Date: Tue Dec 28 09:16:38 2021 +0100 order-properties-on-serialization (#159) commit 96763b9 Author: Antonio Mendoza Pérez <[email protected]> Date: Sat Dec 25 20:16:46 2021 +0100 Fix default values are removed on serialization (#156) * fix-remove-default-values Signed-off-by: Antonio Mendoza Pérez <[email protected]> * removed-ifObject Signed-off-by: Antonio Mendoza Pérez <[email protected]> commit d6fd5d8 Author: Antonio Mendoza Pérez <[email protected]> Date: Sat Dec 25 16:04:44 2021 +0100 update-package-version-4.0.0 (#157) * update-package-version-4.0.0 Signed-off-by: Antonio Mendoza Pérez <[email protected]> * update-package-version-4.0.0 Signed-off-by: Antonio Mendoza Pérez <[email protected]> commit 955dab0 Merge: 255c834 5424a3d Author: Antonio Mendoza Pérez <[email protected]> Date: Thu Dec 9 01:24:04 2021 +0100 Merge pull request #154 from serverlessworkflow/3.0.x changed-package-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened: When I use the following workflow definition and click the button to generate the diagram, nothing happens.
What you expected to happen: I expected the diagram to be generated
How to reproduce it: Using the above json
Anything else we need to know?:
Environment:
The text was updated successfully, but these errors were encountered: