Change to not initialize collections by default on generated POJOs

[hbelmiro]

Fixes #204.

Changes:

• Set initializeCollections jsonschema2pojo property to false
• Added test
• Fixed test that started to fail after setting initializeCollections to false

[tsurdilo]

Can you show what the resulting json (Workflow.toJson(workflow)) looks like with this change?

[hbelmiro]

When initializeCollections = true (current code):

{
  "id" : "functionrefs",
  "name" : "Customer Credit Check Workflow",
  "description" : "Perform Customer Credit Check",
  "version" : "1.0",
  "start" : "TestFunctionRef",
  "specVersion" : "0.8",
  "expressionLang" : "jq",
  "events" : [ ],
  "functions" : [ {
    "name" : "creditCheckFunction",
    "operation" : "http://myapis.org/creditcheckapi.json#doCreditCheck",
    "type" : "rest"
  }, {
    "name" : "sendRejectionEmailFunction",
    "operation" : "http://myapis.org/creditcheckapi.json#rejectionEmail",
    "type" : "rest"
  } ],
  "retries" : [ ],
  "errors" : [ ],
  "secrets" : [ ],
  "states" : [ {
    "actionMode" : "sequential",
    "actions" : [ {
      "functionRef" : "creditCheckFunction"
    }, {
      "functionRef" : {
        "refName" : "sendRejectionEmailFunction",
        "arguments" : {
          "applicant" : "${ .customer }"
        },
        "invoke" : "sync"
      }
    } ],
    "usedForCompensation" : false,
    "name" : "TestFunctionRefs",
    "type" : "operation",
    "end" : true
  } ]
}

When initializeCollections = false (this change):

{
  "id" : "functionrefs",
  "name" : "Customer Credit Check Workflow",
  "description" : "Perform Customer Credit Check",
  "version" : "1.0",
  "start" : "TestFunctionRef",
  "specVersion" : "0.8",
  "events" : [ ],
  "functions" : [ {
    "name" : "creditCheckFunction",
    "operation" : "http://myapis.org/creditcheckapi.json#doCreditCheck",
    "type" : "rest"
  }, {
    "name" : "sendRejectionEmailFunction",
    "operation" : "http://myapis.org/creditcheckapi.json#rejectionEmail",
    "type" : "rest"
  } ],
  "retries" : [ ],
  "errors" : [ ],
  "secrets" : [ ],
  "states" : [ {
    "actionMode" : "sequential",
    "actions" : [ {
      "functionRef" : "creditCheckFunction"
    }, {
      "functionRef" : {
        "refName" : "sendRejectionEmailFunction",
        "arguments" : {
          "applicant" : "${ .customer }"
        },
        "invoke" : "sync"
      }
    } ],
    "usedForCompensation" : false,
    "name" : "TestFunctionRefs",
    "type" : "operation",
    "end" : true
  } ]
}

There's only one difference: "expressionLang" : "jq" didn't appear in the json when initializeCollections = false
This shouldn't happen. If we'll go on with this change, I'll have to investigate it. But this is a different issue.
The most important thing, for what we're discussing, is that annotations doesn't appear in json no matter the value of initializeCollection. This behavior is correct when initializeCollections = false (this change), since Workflow#getAnnotations returns null. But when initializeCollections = true, Workflow#getAnnotations returns an empty list. So an empty array should appear in the resulting json. It looks like the json parser ignores the attribute if it's null or empty.

[tsurdilo]

sdk-java/api/src/main/java/io/serverlessworkflow/api/serializers/WorkflowSerializer.java

Line 66 in 8a61e3c

if (workflow.getAnnotations() != null && !workflow.getAnnotations().isEmpty()) {

[tsurdilo]

if its null or empty it should not be spit out as json/yaml

[tsurdilo]

we need tests that round-trip markup it seems ...will add

[hbelmiro]

Reverted to draft to investigate the jq issue.

[tsurdilo]

There's only one difference: "expressionLang" : "jq" didn't appear in the json

jq is the default value if its not in json/yaml so this should be ok imo

the markup that sdk spits out from object model imo does not 100% have to match the original user markup (for example default prop values and empty arrays can be omitted) , but it has to be semantically the same (and it has to be validatable if original was too)

[hbelmiro]

There's only one difference: "expressionLang" : "jq" didn't appear in the json

jq is the default value if its not in json/yaml so this should be ok imo

the markup that sdk spits out from object model imo does not 100% have to match the original user markup (for example default prop values and empty arrays can be omitted) , but it has to be semantically the same (and it has to be validatable if original was too)

Yes. Makes sense.

[hbelmiro]

we need tests that round-trip markup it seems ...will add

@tsurdilo Just to clarify, you need to add these tests before we move on with this PR?

[tsurdilo]

we need tests that round-trip markup it seems ...will add

@tsurdilo Just to clarify, you need to add these tests before we move on with this PR?

Yes, I'm updating all tests to make sure the json+yaml outputs are validated. This could help us figure out all possible issues the code might have right now and then we can look how to handle them. Hope thats ok with you.

[hbelmiro]

@tsurdilo did you manage to update the tests you mention above so we can move this PR forward?
If you need any help with that, just let me know.

[hbelmiro]

@manick02 do you mind taking a look at this PR? I'm not sure if @tsurdilo is seeing my messages.
If you have any questions or need any clarification on this, please don't hesitate to ask me.