Skip to content

Improve error message when no valid task is found #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fjtirado opened this issue Dec 19, 2024 · 0 comments · Fixed by #499
Closed

Improve error message when no valid task is found #498

fjtirado opened this issue Dec 19, 2024 · 0 comments · Fixed by #499
Assignees
@fjtirado

Comments

@fjtirado
Copy link
Collaborator

Currently for workflows that are not compliant with the spec, a long stack trace is printed as natural result of a failed parsing.
This long stack trace contains details of the failure, but they are expressed as java exception, which are sometimes difficulty to interpret.
It would be better (sacrificing some perfomance to increase usabillity) to validate the file againts the DSL schema before proceeding with the parsing. The validation will give the user, in one shot, all the format errors.
@fjtirado fjtirado self-assigned this Dec 19, 2024
fjtirado added a commit to fjtirado/sdk-java that referenced this issue Dec 19, 2024
@fjtirado
[Fix serverlessworkflow#498] Adding possibility to validate before pa…
045b536 
…rsing

Fix serverlessworkflow#498
fjtirado added a commit to fjtirado/sdk-java that referenced this issue Dec 19, 2024
@fjtirado
[Fix serverlessworkflow#498] Adding possibility to validate before pa…
c17770c 
…rsing

Fix serverlessworkflow#498

Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
@fjtirado fjtirado mentioned this issue Dec 19, 2024
Merged
fjtirado added a commit to fjtirado/sdk-java that referenced this issue Dec 19, 2024
@fjtirado
[Fix serverlessworkflow#498] Adding possibility to validate before pa…
f5a3cbe 
…rsing

Fix serverlessworkflow#498

Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado added a commit to fjtirado/sdk-java that referenced this issue Dec 19, 2024
@fjtirado
[Fix serverlessworkflow#498] Adding possibility to validate before pa…
53c0c5a 
…rsing

Fix serverlessworkflow#498

Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado added a commit to fjtirado/sdk-java that referenced this issue Dec 19, 2024
@fjtirado
[Fix serverlessworkflow#498] Adding possibility to validate before pa…
f763e36 
…rsing

Fix serverlessworkflow#498

Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado added a commit to fjtirado/sdk-java that referenced this issue Dec 19, 2024
@fjtirado
[Fix serverlessworkflow#498] Adding possibility to validate before pa…
b409915 
…rsing

Fix serverlessworkflow#498

Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado added a commit that referenced this issue Dec 20, 2024
@fjtirado
Merge pull request #499 from fjtirado/Fix_#498
22a1c68 
[Fix #498] Adding possibility to validate before parsing
@fjtirado fjtirado mentioned this issue Dec 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fjtirado fjtirado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #498] Adding possibility to validate before parsing fjtirado/sdk-java
1 participant
@fjtirado