Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

chore: update @typescript-eslint to v2 #671

Merged
merged 5 commits into from
May 29, 2023
Merged

chore: update @typescript-eslint to v2 #671

merged 5 commits into from
May 29, 2023

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented May 25, 2023

What did you implement:

Updates to the next major version of @typescript-eslint - it's not the highest, but it's higher :)

How did you implement it:

Because of changes in how linting works, I had to create a new configuration for TypeScript to use when building that just includes the project files - that way the main config can include all files which is needed for @typescript-eslint to be able to lint them properly with typechecking.

This is a common pattern that I use in my most of my projects, and has the same build output.

How can we verify it:

Run the linting and compiling commands.

Also, running colordiff -r against the lib generated by npm run compile on master vs this branch shows no differences:

serverless-azure-functions on  master [?] is 📦 v2.2.1 via  v18.11.0
❯ colordiff -r lib lib2

serverless-azure-functions on  master [?] is 📦 v2.2.1 via  v18.11.0
❯ echo $?
0

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@G-Rath G-Rath changed the title Update typescript eslint chore: update @typescript-eslint to v2 May 25, 2023
@G-Rath

This comment was marked as resolved.

@G-Rath
Copy link
Contributor Author

G-Rath commented May 25, 2023

@gligorkot let me know if you'd like the TypeScript build change pulled out into its own PR for tidiness :)

@gligorkot gligorkot merged commit 65560e4 into serverless:master May 29, 2023
@gligorkot
Copy link
Contributor

Good work @G-Rath, thank you for this.

@G-Rath G-Rath deleted the update-typescript-eslint branch May 29, 2023 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants