This repository was archived by the owner on Dec 9, 2024. It is now read-only.
chore: update @typescript-eslint
to v2
#671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Updates to the next major version of
@typescript-eslint
- it's not the highest, but it's higher :)How did you implement it:
Because of changes in how linting works, I had to create a new configuration for TypeScript to use when building that just includes the project files - that way the main config can include all files which is needed for
@typescript-eslint
to be able to lint them properly with typechecking.This is a common pattern that I use in my most of my projects, and has the same build output.
How can we verify it:
Run the linting and compiling commands.
Also, running
colordiff -r
against thelib
generated bynpm run compile
onmaster
vs this branch shows no differences:Todos:
Note: Run
npm run test:ci
to run all validation checks on proposed changesValidate via
npm run lint
Note: Some reported issues can be automatically fixed by running
npm run lint:fix
Validate via
npm test
Is this ready for review?: YES
Is it a breaking change?: NO