This repository was archived by the owner on Dec 9, 2024. It is now read-only.
fix: remove unneeded acorn
dependency
#669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
The
acorn
package is no longer being used, so it doesn't need to be listed as a dependency.How did you implement it:
I removed it from
dependencies
inpackage.json
How can we verify it:
If
acorn
was being used by this package, then there should have been a match in either a TypeScript or JavaScript file, which there was not.The tests also will fail if
acorn
is actually needed.Todos:
Note: Run
npm run test:ci
to run all validation checks on proposed changesValidate via
npm run lint
Note: Some reported issues can be automatically fixed by running
npm run lint:fix
Validate via
npm test
Is this ready for review?: YES
Is it a breaking change?: NO