Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

fix: remove unneeded acorn dependency #669

Merged
merged 1 commit into from
May 25, 2023
Merged

fix: remove unneeded acorn dependency #669

merged 1 commit into from
May 25, 2023

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented May 21, 2023

What did you implement:

The acorn package is no longer being used, so it doesn't need to be listed as a dependency.

How did you implement it:

I removed it from dependencies in package.json

How can we verify it:

❯ rg --files-with-matches 'acorn'
examples/typescript-webpack/package-lock.json
integrationTests/configurations/node12-linux/package-lock.json
integrationTests/configurations/node18-linux-webpack/package-lock.json
integrationTests/configurations/node14-windows/package-lock.json
integrationTests/configurations/node14-linux/package-lock.json
integrationTests/configurations/node16-linux/package-lock.json
integrationTests/configurations/node12-linux-webpack/package-lock.json
integrationTests/configurations/node18-windows-webpack/package-lock.json
integrationTests/configurations/node16-windows-webpack/package-lock.json
integrationTests/configurations/node14-windows-webpack/package-lock.json
integrationTests/configurations/node16-windows/package-lock.json
integrationTests/configurations/node16-linux-webpack/package-lock.json
integrationTests/configurations/node12-windows-webpack/package-lock.json
integrationTests/configurations/node18-windows/package-lock.json
integrationTests/configurations/node12-windows/package-lock.json
integrationTests/configurations/node14-linux-webpack/package-lock.json
integrationTests/configurations/node18-linux/package-lock.json
package-lock.json

If acorn was being used by this package, then there should have been a match in either a TypeScript or JavaScript file, which there was not.

The tests also will fail if acorn is actually needed.

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@G-Rath G-Rath mentioned this pull request May 21, 2023
6 tasks
@gligorkot
Copy link
Contributor

@G-Rath looks like acorn is used somewhere...

@G-Rath
Copy link
Contributor Author

G-Rath commented May 25, 2023

@gligorkot there you go - looks like it's being used by a dev dependency. I expect that'll probably go away later as part of upgrading eslint and the likes, but for now it doesn't need to be a standard dependency

@G-Rath G-Rath changed the title fix: remove unused acorn dependency fix: remove unneeded acorn dependency May 25, 2023
@gligorkot
Copy link
Contributor

Cool, happy with that. Thanks for updating it

@gligorkot gligorkot merged commit d5203a5 into serverless:master May 25, 2023
@G-Rath G-Rath deleted the remove-acorn branch May 25, 2023 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants