Skip to content

add example for full stack application (front end and backend) #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

trilom
Copy link
Contributor

@trilom trilom commented Jul 15, 2019

No description provided.

@worldsoup
Copy link
Contributor

@trilom fix the tests and we can merge

@trilom
Copy link
Contributor Author

trilom commented Jul 16, 2019

looking at this, when running npm docs run on my local machine it generates readme.md information, but since the example contains 2 directories with 2 serverless.yml files, when the npm docs run command is run it will generate 2 entries for each of those instead of the desired 1 that we want as reflected above.

Not 100% sure, but it seems we can push this through it it should be fine since the tests don't handle the exact case we are deploying at this time.

@worldsoup
Copy link
Contributor

@trilom did you test it by running 'serverless install' pointed at the directory on the enterprise repo to see if it works as expected with two yml files? if you've confirmed that it works as expected I'll go ahead and merge

@trilom
Copy link
Contributor Author

trilom commented Jul 16, 2019

@worldsoup Yes - the directory being merged has 2 directories and a readme. The readme has instructions for how to deploy the two serverless.yml files. When running serverless install on those per the instructions, they build the desired infrastructure.

@worldsoup worldsoup merged commit d93aac1 into master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants