-
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add license option #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
still working in process. |
0ab72b6
to
42cf193
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request overall looks good to me. Just let me know if you have any concerns about any comments. Thanks again for your contribution!
42cf193
to
b1c28e6
Compare
The pr is now ready😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks for you patient and brilliant work!
Hi @msclock, would you like to apply this patch? I have to admit it is a personal flavor for the ordering with config and auto formatted by yaml sort VSCode plugin. Until we find a more maintainable approach, I will suggest to keep on that. I thin you can just run the following two commands at the root directory of repo to have the patch applied. wget https://gist.githubusercontent.com/huxuan/bf435628259a0531760aa6aa336c1bbb/raw/ec3e9b2f3f6f30af96b184bf85008d2ca582a061/add_license_options.patch
git apply add_license_options.patch |
@huxuan the branch has applied the patch to conform to upstream style. |
close #186
📚 Documentation preview 📚: https://serious-scaffold-python--187.org.readthedocs.build/en/187/