Skip to content

feat: add license option #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

msclock
Copy link
Contributor

@msclock msclock commented Sep 18, 2023

@msclock
Copy link
Contributor Author

msclock commented Sep 18, 2023

still working in process.

@msclock msclock force-pushed the add_license_options branch 5 times, most recently from 0ab72b6 to 42cf193 Compare September 19, 2023 01:50
Copy link
Member

@huxuan huxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request overall looks good to me. Just let me know if you have any concerns about any comments. Thanks again for your contribution!

@msclock msclock force-pushed the add_license_options branch from 42cf193 to b1c28e6 Compare September 19, 2023 13:57
@msclock
Copy link
Contributor Author

msclock commented Sep 19, 2023

The pr is now ready😁

huxuan
huxuan previously approved these changes Sep 19, 2023
Copy link
Member

@huxuan huxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for you patient and brilliant work!

@huxuan
Copy link
Member

huxuan commented Sep 20, 2023

Hi @msclock, would you like to apply this patch?

I have to admit it is a personal flavor for the ordering with config and auto formatted by yaml sort VSCode plugin. Until we find a more maintainable approach, I will suggest to keep on that.

I thin you can just run the following two commands at the root directory of repo to have the patch applied.

wget https://gist.githubusercontent.com/huxuan/bf435628259a0531760aa6aa336c1bbb/raw/ec3e9b2f3f6f30af96b184bf85008d2ca582a061/add_license_options.patch
git apply add_license_options.patch

@msclock
Copy link
Contributor Author

msclock commented Sep 20, 2023

Hi @msclock, would you like to apply this patch?

I have to admit it is a personal flavor for the ordering with config and auto formatted by yaml sort VSCode plugin. Until we find a more maintainable approach, I will suggest to keep on that.

I thin you can just run the following two commands at the root directory of repo to have the patch applied.

wget https://gist.githubusercontent.com/huxuan/bf435628259a0531760aa6aa336c1bbb/raw/ec3e9b2f3f6f30af96b184bf85008d2ca582a061/add_license_options.patch
git apply add_license_options.patch

@huxuan the branch has applied the patch to conform to upstream style.

@huxuan huxuan merged commit 5b42dbe into serious-scaffold:main Sep 20, 2023
@huxuan
Copy link
Member

huxuan commented Sep 20, 2023

@huxuan the branch has applied the patch to conform to upstream style.

Hi @msclock, thanks for your understanding! I also created an issue related to yaml formatter #194 , Serious Scaffold Python (including the whole Serious Scaffold org) is still in an early stage, feel free to propose any ideas.

@msclock msclock deleted the add_license_options branch October 7, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add more license options Further utilize message_after_copy and other messages in copier.
2 participants