Skip to content

Align <VersionPrefix> & <TargetFrameworks> with Serilog.Extensions.Logging (+ bump up outdated package dependencies) #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 19, 2022
Merged

Align <VersionPrefix> & <TargetFrameworks> with Serilog.Extensions.Logging (+ bump up outdated package dependencies) #51

merged 7 commits into from
Jan 19, 2022

Conversation

mmarinchenko
Copy link
Contributor

@mmarinchenko mmarinchenko commented Nov 30, 2021 •
edited
Loading

Fixes #47.
Fixes #50.

This was referenced Nov 30, 2021
Closed
Closed
nblumhardt
nblumhardt reviewed Dec 2, 2021
View reviewed changes
Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good to me, though the switch from RollingFile to File changes quite a bit, so we'll need to make more adjustments if we want to go that direction.

@mmarinchenko
Copy link
Contributor Author

@nblumhardt Can you add recent dotnet SDKs to AppVeyor CI?

@nblumhardt
Copy link
Member

@mmarinchenko you should be able to update appveyor.yml in the PR, to use the Visual Studio 2022 AppVeyor worker image and have that picked up

@mmarinchenko
Copy link
Contributor Author

@nblumhardt Oh, thanks. I thought I would need an access to Serilog account at AppVeyor for this :)

Done.

@nblumhardt nblumhardt merged commit a277cf3 into serilog:dev Jan 19, 2022
@nblumhardt
Copy link
Member

LGTM! Should be a -dev package published soon. Looking forward to seeing how it goes out there. Thanks!

@mmarinchenko
Copy link
Contributor Author

mmarinchenko commented Mar 9, 2022 •
edited
Loading

@nblumhardt FYI. As of 2022/03/09, we have been using Serilog.Extensions.Logging.File version 3.0.0-dev-00065 for about a month in production environment. Everything works smoothly!

@nblumhardt
Copy link
Member

Thanks - will open a release PR shortly 👍

@nblumhardt nblumhardt mentioned this pull request Mar 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nblumhardt nblumhardt Awaiting requested review from nblumhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CVE-2019-0820 on System.Text.RegularExpressions 4.1.0 and 4.3.0 Logger is not disposed along with ServiceProvider
2 participants
@mmarinchenko @nblumhardt