Skip to content

Commit 3ee673e

Browse files
committed
Update coverlet.msbuild to version 3.0.1
The `CollectCoverletReport` target can now be removed as coverlet.msbuild produces a `CoverletReport` MSBuild item by default. Pull request: coverlet-coverage/coverlet#932 Changelog: https://github.com/coverlet-coverage/coverlet/blob/070f2b47ef616a62e7fedc89cfec02eac9560ca9/Documentation/Changelog.md#release-date-2021-01-09
1 parent 3138856 commit 3ee673e

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

tests/Serilog.Formatting.Log4Net.Tests.csproj

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<ItemGroup>
1111
<PackageReference Include="ApprovalTests" Version="5.4.5" />
12-
<PackageReference Include="coverlet.msbuild" Version="2.9.0" />
12+
<PackageReference Include="coverlet.msbuild" Version="3.0.1" PrivateAssets="all" />
1313
<PackageReference Include="FluentAssertions" Version="5.10.3" />
1414
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
1515
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0" />
@@ -26,14 +26,7 @@
2626
<CoverletOutputFormat>cobertura</CoverletOutputFormat>
2727
</PropertyGroup>
2828

29-
<!-- Remove this target once https://github.com/coverlet-coverage/coverlet/pull/932 is merged and a new version of coverlet.msbuild is released -->
30-
<Target Name="CollectCoverletReport" AfterTargets="GenerateCoverageResultAfterTest">
31-
<ItemGroup>
32-
<CoverletReport Include="$(CoverletOutput)*.*" />
33-
</ItemGroup>
34-
</Target>
35-
36-
<Target Name="GenerateHtmlCoverageReport" AfterTargets="CollectCoverletReport" Condition="$(ContinuousIntegrationBuild) != 'true'">
29+
<Target Name="GenerateHtmlCoverageReport" AfterTargets="GenerateCoverageResultAfterTest" Condition="$(ContinuousIntegrationBuild) != 'true'">
3730
<PropertyGroup>
3831
<CoverageReportDirectory>$(CoverletOutput)report</CoverageReportDirectory>
3932
<OpenCommand Condition="$([MSBuild]::IsOSPlatform('Linux'))">xdg-open</OpenCommand>
@@ -44,7 +37,7 @@
4437
<Exec Command="$(OpenCommand) &quot;$(CoverageReportDirectory)/index.html&quot;" Condition="$(OpenCommand) != ''" />
4538
</Target>
4639

47-
<Target Name="UploadCoverageToCodecov" AfterTargets="CollectCoverletReport" Condition="$(ContinuousIntegrationBuild) == 'true'">
40+
<Target Name="UploadCoverageToCodecov" AfterTargets="GenerateCoverageResultAfterTest" Condition="$(ContinuousIntegrationBuild) == 'true'">
4841
<!-- For reference: the file `.config/dotnet-tools.json` was created by running `dotnet new tool-manifest && dotnet tool install Codecov.Tool` -->
4942
<Exec Command="dotnet tool restore" />
5043
<Exec Command="dotnet codecov --file &quot;@(CoverletReport, '&quot; &quot;')&quot;" />

0 commit comments

Comments
 (0)