Skip to content

Commit a9782a4

Browse files
committed
move channelz back to the abstract class
1 parent 1270459 commit a9782a4

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

core/src/main/java/io/grpc/internal/AbstractServerImplBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ final List<? extends ServerStreamTracer.Factory> getTracerFactories() {
276276
return Collections.unmodifiableList(tracerFactories);
277277
}
278278

279-
protected final InternalChannelz getChannelz() {
279+
protected InternalChannelz getChannelz() {
280280
return channelz;
281281
}
282282

core/src/main/java/io/grpc/internal/ServerImplBuilder.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import com.google.common.base.Preconditions;
2020
import io.grpc.Deadline;
21+
import io.grpc.InternalChannelz;
2122
import io.grpc.ServerBuilder;
2223
import io.grpc.ServerStreamTracer;
2324
import java.io.File;
@@ -85,6 +86,11 @@ public void setStatsRecordRealTimeMetrics(boolean value) {
8586
super.setStatsRecordRealTimeMetrics(value);
8687
}
8788

89+
@Override
90+
public InternalChannelz getChannelz() {
91+
return super.getChannelz();
92+
}
93+
8894
@Override
8995
public ObjectPool<? extends Executor> getExecutorPool() {
9096
return super.getExecutorPool();

netty/src/main/java/io/grpc/netty/NettyServerBuilder.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import io.grpc.ExperimentalApi;
3030
import io.grpc.ForwardingServerBuilder;
3131
import io.grpc.Internal;
32-
import io.grpc.InternalChannelz;
3332
import io.grpc.ServerBuilder;
3433
import io.grpc.ServerStreamTracer;
3534
import io.grpc.internal.FixedObjectPool;
@@ -90,8 +89,6 @@ public final class NettyServerBuilder extends ForwardingServerBuilder<NettyServe
9089
private final List<SocketAddress> listenAddresses = new ArrayList<>();
9190

9291
private TransportTracer.Factory transportTracerFactory = TransportTracer.getDefaultFactory();
93-
private InternalChannelz channelz = InternalChannelz.instance();
94-
9592
private ChannelFactory<? extends ServerChannel> channelFactory =
9693
Utils.DEFAULT_SERVER_CHANNEL_FACTORY;
9794
private final Map<ChannelOption<?>, Object> channelOptions = new HashMap<>();
@@ -606,7 +603,7 @@ List<NettyServer> buildTransportServers(
606603
keepAliveTimeInNanos, keepAliveTimeoutInNanos,
607604
maxConnectionIdleInNanos, maxConnectionAgeInNanos,
608605
maxConnectionAgeGraceInNanos, permitKeepAliveWithoutCalls, permitKeepAliveTimeInNanos,
609-
channelz);
606+
this.serverImplBuilder.getChannelz());
610607
transportServers.add(transportServer);
611608
}
612609
return Collections.unmodifiableList(transportServers);

0 commit comments

Comments
 (0)