Skip to content

Commit 9503c00

Browse files
committed
Replace AbstractManagedChannelImplBuilder in ServiceConfigErrorHandlingTest
1 parent e8c6f2f commit 9503c00

File tree

1 file changed

+20
-25
lines changed

1 file changed

+20
-25
lines changed

core/src/test/java/io/grpc/internal/ServiceConfigErrorHandlingTest.java

Lines changed: 20 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646
import io.grpc.NameResolver;
4747
import io.grpc.NameResolver.ConfigOrError;
4848
import io.grpc.Status;
49+
import io.grpc.internal.ManagedChannelImplBuilder.ChannelBuilderDefaultPortProvider;
50+
import io.grpc.internal.ManagedChannelImplBuilder.ClientTransportFactoryBuilder;
4951
import java.net.SocketAddress;
5052
import java.net.URI;
5153
import java.util.ArrayList;
@@ -153,7 +155,18 @@ public ConfigOrError parseLoadBalancingPolicyConfig(
153155
private ObjectPool<Executor> balancerRpcExecutorPool;
154156
@Mock
155157
private Executor blockingExecutor;
156-
private ChannelBuilder channelBuilder;
158+
159+
private ManagedChannelImplBuilder channelBuilder = new ManagedChannelImplBuilder(TARGET,
160+
new ClientTransportFactoryBuilder() {
161+
@Override public ClientTransportFactory buildClientTransportFactory() {
162+
throw new UnsupportedOperationException();
163+
}
164+
},
165+
new ChannelBuilderDefaultPortProvider() {
166+
@Override public int getDefaultPort() {
167+
return DEFAULT_PORT;
168+
}
169+
});
157170

158171
private void createChannel(ClientInterceptor... interceptors) {
159172
checkState(channel == null);
@@ -199,14 +212,12 @@ public void setUp() throws Exception {
199212
.thenReturn(timer.getScheduledExecutorService());
200213
when(executorPool.getObject()).thenReturn(executor.getScheduledExecutorService());
201214

202-
channelBuilder =
203-
new ChannelBuilder()
204-
.nameResolverFactory(new FakeNameResolverFactory.Builder(expectedUri).build())
205-
.defaultLoadBalancingPolicy(MOCK_POLICY_NAME)
206-
.userAgent(USER_AGENT)
207-
.idleTimeout(
208-
AbstractManagedChannelImplBuilder.IDLE_MODE_MAX_TIMEOUT_DAYS, TimeUnit.DAYS)
209-
.offloadExecutor(blockingExecutor);
215+
channelBuilder
216+
.nameResolverFactory(new FakeNameResolverFactory.Builder(expectedUri).build())
217+
.defaultLoadBalancingPolicy(MOCK_POLICY_NAME)
218+
.userAgent(USER_AGENT)
219+
.idleTimeout(ManagedChannelImplBuilder.IDLE_MODE_MAX_TIMEOUT_DAYS, TimeUnit.DAYS)
220+
.offloadExecutor(blockingExecutor);
210221
channelBuilder.executorPool = executorPool;
211222
channelBuilder.binlog = null;
212223
channelBuilder.channelz = channelz;
@@ -529,22 +540,6 @@ public void validConfig_thenNoConfig_withDefaultConfig() throws Exception {
529540
verify(mockLoadBalancer, never()).handleNameResolutionError(any(Status.class));
530541
}
531542

532-
private static final class ChannelBuilder
533-
extends AbstractManagedChannelImplBuilder<ChannelBuilder> {
534-
535-
ChannelBuilder() {
536-
super(TARGET);
537-
}
538-
539-
@Override protected ClientTransportFactory buildTransportFactory() {
540-
throw new UnsupportedOperationException();
541-
}
542-
543-
@Override protected int getDefaultPort() {
544-
return DEFAULT_PORT;
545-
}
546-
}
547-
548543
private static final class FakeBackoffPolicyProvider implements BackoffPolicy.Provider {
549544
@Override
550545
public BackoffPolicy get() {

0 commit comments

Comments
 (0)