feature(hooks): add decorators for declaring hooks #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natesilva
changed the title
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=========================================
+ Coverage 95.65% 96.3% +0.65%
=========================================
Files 66 99 +33
Lines 759 893 +134
Branches 106 114 +8
=========================================
+ Hits 726 860 +134
Misses 11 11
Partials 22 22
Continue to review full report at Codecov.
|
|
Great job. I've added one comment to your code :) |
| export function AfterBulkCreate(options: IHookOptions): Function; | ||
| export function AfterBulkCreate(...args: any[]): void|Function { | ||
|
|
||
| if (args.length === 1) { |
There was a problem hiding this comment.
I would suggest to separate this (line 8-20) to an additional method in the hooks service cause these lines appear in every hook annotation. What do you think?
|
I messed up this branch. Re-opened the pull request as #101. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decorators for declaring hook methods in Model classes.
Includes README update, tests (100% coverage of new code).
Fixes #88