Fixing findOrCreate and findCreateFind #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Fixing findOrCreate to allow any values or a specific interface A. This matches the findOrBuild definition. 2) Fixing findCreateFind to return the correct value [Model, boolean], and also apply the same fix as sequelize#1.
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 65 65
Lines 745 745
Branches 101 101
=======================================
Hits 712 712
Misses 11 11
Partials 22 22Continue to review full report at Codecov.
|
|
@kingjerod Looks good, thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing findOrCreate to allow any values or a specific interface A. This matches the findOrBuild definition.
Fixing findCreateFind to return the correct value [Model, boolean], and also apply the same fix as @Column and @PrimaryKey annotation do not work together properly #1.