Use esModuleInterop and fix corresponding issues #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 117 117
Lines 1019 1019
Branches 133 133
=======================================
Hits 985 985
Misses 15 15
Partials 19 19
Continue to review full report at Codecov.
|
|
Ha, I never thought of using |
|
I just published a new release including this change: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330
I've also tried bumping
typescriptand settingesModuleInteroptotrue. The proposed changes also worked with the newer version, but I'm not sure if that would introduce a breaking change tosequelize-typescript. The recommendation seems to be to set that flag to true when you can.I've taken the solution from this issue microsoft/TypeScript#21535 (comment)