Skip to content

fix Model.changed method arguments description #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

vologab
Copy link
Contributor

@vologab vologab commented Jan 16, 2018

@codecov-io
Copy link

Codecov Report

Merging #269 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #269   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         115      115           
  Lines        1004     1004           
  Branches      129      129           
=======================================
  Hits          971      971           
  Misses         15       15           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80b935...b123b3b. Read the comment docs.

@RobinBuschmann
Copy link
Member

Hey @vologab, thanks for contributing. Can you provide a link where this is documented? Thank you :)

@vologab
Copy link
Contributor Author

vologab commented Jan 17, 2018

Hi @RobinBuschmann. I've put link to sequelize repo inside commit message:
https://github.com/sequelize/sequelize/blob/master/lib/model.js#L3382.
Also issue when we have to use second param: sequelize/sequelize#2862

@RobinBuschmann
Copy link
Member

Sry, I have overseen that.

@RobinBuschmann RobinBuschmann merged commit 4302356 into sequelize:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants