Skip to content

tableName bug fix #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

tableName bug fix #148

wants to merge 1 commit into from

Conversation

skarahoda
Copy link

Setting tableName is unnecessary. It prevents to use underscoredAll option.

Setting tableName is unnecessary. It prevents to use underscoredAll option.
@RobinBuschmann
Copy link
Member

Hey @skarahoda, in sequelize-typescript the class name should be set as default table name - it isn't unnecessary. Nevertheless I do understand that setting tableName in the table annotation prevents the usage of the underscoreAll option. Probably there is another way to achieve this

@skarahoda
Copy link
Author

Hey @RobinBuschmann thanks for response. For sequelize.define function tableName is an optional parameter. You can check the link also. sequelize can set tableName with given options. If sequelize-typescript interferes this behavior, you are right. Please help me to fix this tiny problem so I can use underscoredAll option with seqelize-typescript in an elegant way.

@RobinBuschmann
Copy link
Member

@skarahoda I found a solution: Setting freezeTableName to true by default instead of using class name as default table name does the job and it should make it also possible to use underscoredAll.

I will create a pull request and close this one.

Thanks for bringing this up :)

RobinBuschmann added a commit that referenced this pull request Oct 4, 2017
@skarahoda skarahoda deleted the patch-1 branch October 5, 2017 15:46
@skarahoda
Copy link
Author

Thank you @RobinBuschmann :)
Just for curiosity, when will you publish the new version?

@RobinBuschmann
Copy link
Member

I will try to publish a new beta release on this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants