Skip to content

Drop sequelize version 3 support for future releases #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RobinBuschmann opened this issue Oct 7, 2017 · 6 comments
Closed

Drop sequelize version 3 support for future releases #157

RobinBuschmann opened this issue Oct 7, 2017 · 6 comments
Milestone

Comments

@RobinBuschmann
Copy link
Member

Supporting v3 and v4 at the same time makes the code base unnecessarily complex and improvements much more difficult. Since sequelize v4 is available for some month now, I think it makes sense to drop support for version 3.

@bilby91 @snewell92 @BruceHem What do you think about it?

@bilby91
Copy link
Contributor

bilby91 commented Oct 7, 2017 via email

@chanlito
Copy link
Contributor

chanlito commented Oct 8, 2017

@RobinBuschmann to be honest, I think it's best to drop support for v3.

@nullpixel
Copy link

+1

@snewell92
Copy link
Contributor

I agree.

And if someone needs v3 support (lock in on production or something), it would be easy to either 1, pin sequelize-typescript to an older version with v3 support, or 2 - fork this repo, reset to a commit with v3 support, and just use that indefinitely (since sequelize v3 isn't going to undergo any major breaking changes, barring some security issue... in which case the sequelize team may still just advise to update to v4).

Let's do eeeeet!

@RobinBuschmann
Copy link
Member Author

Sequelize version 3 support will be dropped with [email protected]. [email protected] will be the last minor release before 1.0.0.

@RobinBuschmann RobinBuschmann added this to the 1.0 milestone Nov 27, 2017
@RobinBuschmann
Copy link
Member Author

Dropped on [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants