Skip to content

Move @types/sequelize constraint to >= ? #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bilby91 opened this issue Sep 21, 2017 · 3 comments
Closed

Move @types/sequelize constraint to >= ? #142

bilby91 opened this issue Sep 21, 2017 · 3 comments

Comments

@bilby91
Copy link
Contributor

bilby91 commented Sep 21, 2017

Hey @RobinBuschmann,

Are you okey if we change the @types/sequelize constraint to >= ? We are not able to use the latest types that include some definitions that we need.

Thanks!

@RobinBuschmann
Copy link
Member

Hey @bilby91 , I thought about it too. But the problem is, in case of typings that are not compatible with sequelize-typescript, we wouldn't notice the issue fast enough. So that all beginners new to sequelize-typescript couldn't use sequelize-typescript until the typings are fixed.
Let us publish patch releases with the latest typings more frequently instead. So that we have full control over it :) what do you think?

@bilby91
Copy link
Contributor Author

bilby91 commented Sep 22, 2017

Hi @RobinBuschmann ! Sure, that should work. I was thinking of another option maybe. Having a CI run with the latest version always. I guess the problem with that will be that if we don't commit frequently to the repo we won't notice the incompatibility. Let's go with your idea!

@bilby91
Copy link
Contributor Author

bilby91 commented Sep 22, 2017

@RobinBuschmann #143 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants