Fixed Delta serialization when None type is present. #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 99.63% 99.60% -0.04%
==========================================
Files 13 13
Lines 2733 2753 +20
==========================================
+ Hits 2723 2742 +19
- Misses 10 11 +1
Continue to review full report at Codecov.
|
seperman
commented
Jan 14, 2021
| @@ -254,10 +256,40 @@ def find_class(self, module, name): | |||
| # Forbid everything else. | |||
| raise ForbiddenModule(FORBIDDEN_MODULE_MSG.format(module_dot_class)) from None | |||
|
|
|||
| def persistent_load(self, persistent_id): | |||
| if persistent_id == "<<NoneType>>": | |||
There was a problem hiding this comment.
I'm not super happy with this solution but I didn't find a better solution to the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Delta serialization when None type is present.
Fixes #224