Skip to content

Commit 2a10230

Browse files
Merge Conflicts
2 parents 3fae8b8 + 1fdcc3f commit 2a10230

File tree

6 files changed

+61
-49
lines changed

6 files changed

+61
-49
lines changed

CHANGELOG.md

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -6,37 +6,37 @@ This project adheres to [Semantic Versioning](http://semver.org/).
66
## [3.1.0] - 2018-05-23
77
### Added
88
- [Update register.py to use pypandoc](https://github.com/sendgrid/python-http-client/commit/6a3a63e2511b3df9c9ef23eebd5bcd80ad8821ae)
9-
- [PR #21](https://github.com/sendgrid/python-http-client/pull/21): Support timeout. Thanks [George Kussumoto](https://github.com/georgeyk)!
10-
- [PR #22](https://github.com/sendgrid/python-http-client/pull/22): Client can be pickled and unpickled. Thanks [Jussi Heikkilä](https://github.com/jussih)!
11-
- [PR #26](https://github.com/sendgrid/python-http-client/pull/26): Create CODE_OF_CONDUCT.md. Thanks [Fredrik Svensson](https://github.com/SvenssonWeb)!
12-
- [PR #30](https://github.com/sendgrid/python-http-client/pull/30): Create TROUBLESHOOTING.md. Thanks [Omer Ahmed Khan](https://github.com/OmerAhmedKhan)!
13-
- [PR #33](https://github.com/sendgrid/python-http-client/pull/33): Update README.md badges and license. Thanks [Alfred Gutierrez](https://github.com/alfg)!
14-
- [PR #34](https://github.com/sendgrid/python-http-client/pull/34): Update .md files for SEO. Thanks [Gustavo Siqueira](https://github.com/gugsrs)!
15-
- [PR #36](https://github.com/sendgrid/python-http-client/pull/36): Added more badges to README.md. Thanks [Shivam Agarwal](https://github.com/gr8shivam)!
16-
- [PR #41](https://github.com/sendgrid/python-http-client/pull/41): Added License link to README ToC. Thanks [Andrew Joshua Loria](https://github.com/ajloria)!
17-
- [PR #49](https://github.com/sendgrid/python-http-client/pull/49): Add USAGE.md. Thanks [Adelmo Junior](https://github.com/noblehelm)!
18-
- [PR #43](https://github.com/sendgrid/python-http-client/pull/43): Add PULL_REQUEST_TEMPLATE. Thanks [Aleksandr Sobolev](https://github.com/s0b0lev)!
19-
- [PR #50](https://github.com/sendgrid/python-http-client/pull/50): Add Docker files and update README. Thanks [Stanley Ndagi](https://github.com/NdagiStanley)!
20-
- [PR #69](https://github.com/sendgrid/python-http-client/pull/69): Simplify GitHub PR template. Thanks [Alex](https://github.com/pushkyn)!
21-
- [PR #61](https://github.com/sendgrid/python-http-client/pull/61): License date range UnitTest. Thanks [Anfernee Sodusta](https://github.com/dinosaurfiles)!
22-
- [PR #60](https://github.com/sendgrid/python-http-client/pull/60): Adds test for repo files. Thanks [Cheuk Yin Ng](https://github.com/cheukyin699)!
23-
- [PR #47](https://github.com/sendgrid/python-http-client/pull/47): Add .env_sample file. Thanks [Rod Xavier](https://github.com/rodxavier)!
24-
- [PR #66](https://github.com/sendgrid/python-http-client/pull/66): Update travis.yml to fail on Pep8 errors. Thanks [Stanley Ndagi](https://github.com/NdagiStanley)!
25-
- [PR #67](https://github.com/sendgrid/python-http-client/pull/67): Made python-http-client comply with autopep8. Thanks [Madhur Garg](https://github.com/Madhur96)!
26-
- [PR #81](https://github.com/sendgrid/python-http-client/pull/81): PEP8 updates. Thanks [~](https://github.com/delirious-lettuce)!
27-
- [PR #73](https://github.com/sendgrid/python-http-client/pull/73): Add CodeCov support to .travis.yml. Thanks [Senthil](https://github.com/senthilkumar-e)!
28-
- [PR #77](https://github.com/sendgrid/python-http-client/pull/77): Include code review in README.md. Thanks [Jared Scott](https://github.com/jlax47)!
29-
- [PR #87](https://github.com/sendgrid/python-http-client/pull/87): Add manifest that includes the license in sdist. Thanks [RohitK89](https://github.com/RohitK89)!
9+
- [PR #21](https://github.com/sendgrid/python-http-client/pull/21): Support timeout. Thanks, [George Kussumoto](https://github.com/georgeyk)!
10+
- [PR #22](https://github.com/sendgrid/python-http-client/pull/22): Client can be pickled and unpickled. Thanks, [Jussi Heikkilä](https://github.com/jussih)!
11+
- [PR #26](https://github.com/sendgrid/python-http-client/pull/26): Create CODE_OF_CONDUCT.md. Thanks, [Fredrik Svensson](https://github.com/SvenssonWeb)!
12+
- [PR #30](https://github.com/sendgrid/python-http-client/pull/30): Create TROUBLESHOOTING.md. Thanks, [Omer Ahmed Khan](https://github.com/OmerAhmedKhan)!
13+
- [PR #33](https://github.com/sendgrid/python-http-client/pull/33): Update README.md badges and license. Thanks, [Alfred Gutierrez](https://github.com/alfg)!
14+
- [PR #34](https://github.com/sendgrid/python-http-client/pull/34): Update .md files for SEO. Thanks, [Gustavo Siqueira](https://github.com/gugsrs)!
15+
- [PR #36](https://github.com/sendgrid/python-http-client/pull/36): Added more badges to README.md. Thanks,, [Shivam Agarwal](https://github.com/gr8shivam)!
16+
- [PR #41](https://github.com/sendgrid/python-http-client/pull/41): Added License link to README ToC. Thanks,, [Andrew Joshua Loria](https://github.com/ajloria)!
17+
- [PR #49](https://github.com/sendgrid/python-http-client/pull/49): Add USAGE.md. Thanks, [Adelmo Junior](https://github.com/noblehelm)!
18+
- [PR #43](https://github.com/sendgrid/python-http-client/pull/43): Add PULL_REQUEST_TEMPLATE. Thanks, [Aleksandr Sobolev](https://github.com/s0b0lev)!
19+
- [PR #50](https://github.com/sendgrid/python-http-client/pull/50): Add Docker files and update README. Thanks, [Stanley Ndagi](https://github.com/NdagiStanley)!
20+
- [PR #69](https://github.com/sendgrid/python-http-client/pull/69): Simplify GitHub PR template. Thanks, [Alex](https://github.com/pushkyn)!
21+
- [PR #61](https://github.com/sendgrid/python-http-client/pull/61): License date range UnitTest. Thanks, [Anfernee Sodusta](https://github.com/dinosaurfiles)!
22+
- [PR #60](https://github.com/sendgrid/python-http-client/pull/60): Adds test for repo files. Thanks, [Cheuk Yin Ng](https://github.com/cheukyin699)!
23+
- [PR #47](https://github.com/sendgrid/python-http-client/pull/47): Add .env_sample file. Thanks, [Rod Xavier](https://github.com/rodxavier)!
24+
- [PR #66](https://github.com/sendgrid/python-http-client/pull/66): Update travis.yml to fail on Pep8 errors. Thanks, [Stanley Ndagi](https://github.com/NdagiStanley)!
25+
- [PR #67](https://github.com/sendgrid/python-http-client/pull/67): Made python-http-client comply with autopep8. Thanks, [Madhur Garg](https://github.com/Madhur96)!
26+
- [PR #81](https://github.com/sendgrid/python-http-client/pull/81): PEP8 updates. Thanks, [~](https://github.com/delirious-lettuce)!
27+
- [PR #73](https://github.com/sendgrid/python-http-client/pull/73): Add CodeCov support to .travis.yml. Thanks, [Senthil](https://github.com/senthilkumar-e)!
28+
- [PR #77](https://github.com/sendgrid/python-http-client/pull/77): Include code review in README.md. Thanks, [Jared Scott](https://github.com/jlax47)!
29+
- [PR #87](https://github.com/sendgrid/python-http-client/pull/87): Add manifest that includes the license in sdist. Thanks, [RohitK89](https://github.com/RohitK89)!
3030

3131
### Fixed
32-
- [PR #24](https://github.com/sendgrid/python-http-client/pull/24): Fix Typo in CONTRIBUTING.md. Thanks [Cícero Pablo](https://github.com/ciceropablo)!
33-
- [PR #23](https://github.com/sendgrid/python-http-client/pull/23): Fix Typo in README.md. Thanks [Cícero Pablo](https://github.com/ciceropablo)!
34-
- [PR #28](https://github.com/sendgrid/python-http-client/pull/28): Fix Travis CI Build. Thanks [Kevin Anderson](https://github.com/kevinanderson1)!
35-
- [PR #40](https://github.com/sendgrid/python-http-client/pull/40): Update contributing and readme - fix typo, ToC. Thanks [Alex](https://github.com/pushkyn)!
36-
- [PR #54](https://github.com/sendgrid/python-http-client/pull/54): Fix code style issues. Thanks [Stephen James](https://github.com/StephenOrJames)!
37-
- [PR #82](https://github.com/sendgrid/python-http-client/pull/82): PEP8 updates. Thanks [~](https://github.com/delirious-lettuce)!
38-
- [PR #83](https://github.com/sendgrid/python-http-client/pull/83): Fix Travis build errors. Thanks [~](https://github.com/delirious-lettuce)!
39-
- [PR #84](https://github.com/sendgrid/python-http-client/pull/84): Fix docstring variable name. Thanks [~](https://github.com/delirious-lettuce)!
32+
- [PR #24](https://github.com/sendgrid/python-http-client/pull/24): Fix Typo in CONTRIBUTING.md. Thanks, [Cícero Pablo](https://github.com/ciceropablo)!
33+
- [PR #23](https://github.com/sendgrid/python-http-client/pull/23): Fix Typo in README.md. Thanks, [Cícero Pablo](https://github.com/ciceropablo)!
34+
- [PR #28](https://github.com/sendgrid/python-http-client/pull/28): Fix Travis CI Build. Thanks, [Kevin Anderson](https://github.com/kevinanderson1)!
35+
- [PR #40](https://github.com/sendgrid/python-http-client/pull/40): Update contributing and readme - fix typo, ToC. Thanks, [Alex](https://github.com/pushkyn)!
36+
- [PR #54](https://github.com/sendgrid/python-http-client/pull/54): Fix code style issues. Thanks, [Stephen James](https://github.com/StephenOrJames)!
37+
- [PR #82](https://github.com/sendgrid/python-http-client/pull/82): PEP8 updates. Thanks, [~](https://github.com/delirious-lettuce)!
38+
- [PR #83](https://github.com/sendgrid/python-http-client/pull/83): Fix Travis build errors. Thanks, [~](https://github.com/delirious-lettuce)!
39+
- [PR #84](https://github.com/sendgrid/python-http-client/pull/84): Fix docstring variable name. Thanks, [~](https://github.com/delirious-lettuce)!
4040
- Fix [Issue #86](https://github.com/sendgrid/python-http-client/issues/86): Error converting Response.to_dict.
4141

4242
## [3.0.0] - 2017-08-11
@@ -47,12 +47,12 @@ This project adheres to [Semantic Versioning](http://semver.org/).
4747
## [2.4.0] - 2017-07-03
4848
### Added
4949
- #19 Added support for slash. Created "to_dict" property in response object and exception class.
50-
- Thanks [Lucas Cardoso](https://github.com/MrLucasCardoso)!
50+
- Thanks, [Lucas Cardoso](https://github.com/MrLucasCardoso)!
5151

5252
## [2.3.0] - 2017-06-20
5353
### Added
5454
- #17 Added support for error handling
55-
- Thanks [Dibya Prakash Das](https://github.com/dibyadas)!
55+
- Thanks, [Dibya Prakash Das](https://github.com/dibyadas)!
5656

5757
## [2.2.1] - 2016-08-10
5858
### Fixed
@@ -65,7 +65,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
6565
## [2.1.1] - 2016-07-08
6666
### Fixed
6767
- [Allow multiple values for a parameter](https://github.com/sendgrid/python-http-client/pull/11)
68-
- Thanks [Chris Henry](https://github.com/chrishenry)!
68+
- Thanks, [Chris Henry](https://github.com/chrishenry)!
6969

7070
## [2.1.0] - 2016-06-03
7171
### Added
@@ -82,14 +82,14 @@ This project adheres to [Semantic Versioning](http://semver.org/).
8282
## [1.2.3] - 2016-03-01
8383
### Added
8484
- Can now reuse part of the chaining construction for multiple urls/requests
85-
- Thanks to [Kevin Gillette](https://github.com/extemporalgenome)!
85+
- Thanks, to [Kevin Gillette](https://github.com/extemporalgenome)!
8686
- Update of request headers simplified
87-
- Thanks to [Matt Bernier](https://github.com/mbernier)
87+
- Thanks, to [Matt Bernier](https://github.com/mbernier)
8888

8989
## [1.1.3] - 2016-02-29
9090
### Fixed
9191
- Various standardizations for commenting, syntax, pylint
92-
- Thanks to [Ian Douglas](https://github.com/iandouglas)!
92+
- Thanks, to [Ian Douglas](https://github.com/iandouglas)!
9393

9494
## [1.1.2] - 2016-02-29
9595
### Fixed

CODE_OF_CONDUCT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Members of the community are open to collaboration, whether it's on pull request
99
Members of the community are considerate of their peers, which include other contributors and users of SendGrid. We're thoughtful when addressing the efforts of others, keeping in mind that often the labor was completed with the intent of the good of the community. We're attentive in our communications, whether in person or online, and we're tactful when approaching differing views.
1010

1111
### Be Respectful
12-
Members of the community are respectful. We're respectful of others, their positions, their skills, their commitments and their efforts. We're respectful of the volunteer efforts that permeate the SendGrid community. We're respectful of the processes outlined in the community, and we work within them. When we disagree, we are courteous in raising our issues. Overall, we're good to each other. We contribute to this community not because we have to, but because we want to. If we remember that, these guidelines will come naturally.
12+
Members of the community are respectful. We're respectful of others, their positions, their skills, their commitments, and their efforts. We're respectful of the volunteer efforts that permeate the SendGrid community. We're respectful of the processes outlined in the community, and we work within them. When we disagree, we are courteous in raising our issues. Overall, we're good with each other. We contribute to this community not because we have to, but because we want to. If we remember that, these guidelines will come naturally.
1313

1414
## Additional Guidance
1515

CONTRIBUTING.md

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,34 @@
11
Hello! Thank you for choosing to help contribute to one of the SendGrid open source projects. There are many ways you can contribute and help is always welcome. We simply ask that you follow the following contribution policies.
22

3-
- [CLAs and CCLAs](#cla)
4-
- [Roadmap & Milestones](#roadmap)
3+
- [CLAs and CCLAs](#clas-and-cclas)
54
- [Feature Request](#feature-request)
65
- [Submit a Bug Report](#submit-a-bug-report)
6+
- [Please use our Bug Report Template](#please-use-our-bug-report-template)
77
- [Improvements to the Codebase](#improvements-to-the-codebase)
8-
- [Understanding the Code Base](#understanding-the-codebase)
8+
- [Development Environment](#development-environment)
9+
- [Install and Run Locally](#install-and-run-locally)
10+
- [Prerequisites](#prerequisites)
11+
- [Initial setup:](#initial-setup)
12+
- [Execute:](#execute)
13+
- [Understanding the Code Base](#understanding-the-code-base)
914
- [Testing](#testing)
1015
- [Testing Multiple Versions of Python](#testing-multiple-versions-of-python)
11-
- [Style Guidelines & Naming Conventions](#style-guidelines-and-naming-conventions)
16+
- [Prerequisites:](#prerequisites)
17+
- [Initial setup:](#initial-setup-1)
18+
- [Execute:](#execute-1)
19+
- [Style Guidelines & Naming Conventions](#style-guidelines--naming-conventions)
1220
- [Creating a Pull Request](#creating-a-pull-request)
1321
- [Code Reviews](#code-reviews)
1422

1523
<a name="roadmap"></a>
16-
We use [Milestones](https://github.com/sendgrid/python-http-client/milestones) to help define current roadmaps, please feel free to grab an issue from the current milestone. Please indicate that you have begun work on it to avoid collisions. Once a PR is made, community review, comments, suggestions and additional PRs are welcomed and encouraged.
24+
We use [Milestones](https://github.com/sendgrid/python-http-client/milestones) to help define current roadmaps, please feel free to grab an issue from the current milestone. Please indicate that you have begun work on it to avoid collisions. Once a PR is made, community review, comments, suggestions, and additional PRs are welcomed and encouraged.
1725

1826
<a name="cla"></a>
1927
## CLAs and CCLAs
2028

2129
Before you get started, SendGrid requires that a SendGrid Contributor License Agreement (CLA) be filled out by every contributor to a SendGrid open source project.
2230

23-
Our goal with the CLA is to clarify the rights of our contributors and reduce other risks arising from inappropriate contributions. The CLA also clarifies the rights SendGrid holds in each contribution and helps to avoid misunderstandings over what rights each contributor is required to grant to SendGrid when making a contribution. In this way the CLA encourages broad participation by our open source community and helps us build strong open source projects, free from any individual contributor withholding or revoking rights to any contribution.
31+
Our goal with the CLA is to clarify the rights of our contributors and reduce other risks arising from inappropriate contributions. The CLA also clarifies the rights SendGrid holds in each contribution and helps to avoid misunderstandings over what rights each contributor is required to grant to SendGrid when making a contribution. In this way, the CLA encourages broad participation by our open source community and helps us build strong open source projects, free from any individual contributor withholding or revoking rights to any contribution.
2432

2533
SendGrid does not merge a pull request made against a SendGrid open source project until that pull request is associated with a signed CLA. Copies of the CLA are available [here](https://gist.github.com/SendGridDX/98b42c0a5d500058357b80278fde3be8#file-sendgrid_cla).
2634

@@ -47,8 +55,8 @@ A software bug is a demonstrable issue in the code base. In order for us to diag
4755

4856
Before you decide to create a new issue, please try the following:
4957

50-
1. Check the GitHub issues tab if the identified issue has already been reported, if so, please add a +1 to the existing post.
51-
2. Update to the latest version of this code and check if issue has already been fixed
58+
1. Check the Github issues tab if the identified issue has already been reported, if so, please add a +1 to the existing post.
59+
2. Update to the latest version of this code and check if the issue has already been fixed
5260
3. Copy and fill in the Bug Report Template we have provided below
5361

5462
### Please use our Bug Report Template
@@ -187,6 +195,7 @@ Please run your code through:
187195
```
188196

189197
3. Create a new topic branch off the `development` branch to
198+
190199
contain your feature, change, or fix:
191200

192201
```bash
@@ -196,7 +205,7 @@ Please run your code through:
196205

197206
4. Commit your changes in logical chunks. Please adhere to these [git commit
198207
message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
199-
or your code is unlikely be merged into the main project. Use Git's
208+
or your code is unlikely to be merged into the main project. Use Git's
200209
[interactive rebase](https://help.github.com/articles/interactive-rebase)
201210
feature to tidy up your commits before making them public.
202211

TROUBLESHOOTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
When debugging or testing, it may be useful to examine the raw request body.
99

10-
You can do this just after call `response = client.your.api._(param).call.<METHOD>` Where <METHOD> can be `get()`, `post()`, `patch()` and `post()`.
10+
You can do this just after the call `response = client.your.api._(param).call.<METHOD>` Where <METHOD> can be `get()`, `post()`, `patch()` and `post()`.
1111

1212
```python
1313
print(response.body)

USAGE.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ request_headers = {
99
"Authorization": 'Bearer {0}'.format(api_key)
1010
}
1111
version = 3
12-
client = python_http_client.Client(host=host,
13-
request_headers=request_headers,
14-
version=version)
12+
client = python_http_client.Client(
13+
host=host,
14+
request_headers=request_headers,
15+
version=version
16+
)
1517
```
1618

1719
# Table of Contents

USE_CASES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
This document provides examples for specific use cases. Please [open an issue](https://github.com/sendgrid/python-http-client/issues) or make a pull request for any use cases you would like us to document here. Thank you!

0 commit comments

Comments
 (0)