Pulls HTTP methods to class attr

Author: 0bsearch

python_http_client/client.py

@@ -1,5 +1,6 @@
 """HTTP Client library"""
 import json
+
 from .exceptions import handle_error
 
 try:
@@ -62,6 +63,9 @@ def to_dict(self):
 class Client(object):
     """Quickly and easily access any REST or REST-like API."""
 
+    # These are the supported HTTP verbs
+    methods = set(('delete', 'get', 'patch', 'post', 'put'))
+
     def __init__(self,
                  host,
                  request_headers=None,
@@ -88,8 +92,6 @@ def __init__(self,
         self._version = version
         # _url_path keeps track of the dynamically built url
         self._url_path = url_path or []
-        # These are the supported HTTP verbs
-        self.methods = ['delete', 'get', 'patch', 'post', 'put']
         # APPEND SLASH set
         self.append_slash = append_slash
         self.timeout = timeout

tests/test_unit.py

@@ -84,7 +84,7 @@ def test__init__(self):
         self.assertEqual(default_client.host, self.host)
         self.assertEqual(default_client.request_headers, {})
         self.assertIs(default_client.timeout, None)
-        methods = ['delete', 'get', 'patch', 'post', 'put']
+        methods = set(('delete', 'get', 'patch', 'post', 'put'))
         self.assertEqual(default_client.methods, methods)
         self.assertEqual(default_client._version, None)
         self.assertEqual(default_client._url_path, [])
@@ -97,7 +97,7 @@ def test__init__(self):
                         timeout=10)
         self.assertEqual(client.host, self.host)
         self.assertEqual(client.request_headers, request_headers)
-        methods = ['delete', 'get', 'patch', 'post', 'put']
+        methods = set(('delete', 'get', 'patch', 'post', 'put'))
         self.assertEqual(client.methods, methods)
         self.assertEqual(client._version, 3)
         self.assertEqual(client._url_path, [])
@@ -151,7 +151,7 @@ def test__getattr__(self):
         self.assertEqual(client._version, 3)
 
         # Test GET
-        mock_client._url_path + ['test']
+        mock_client._url_path += ['test']
         r = mock_client.get()
         self.assertEqual(r.status_code, 200)