Merge pull request #58 from mptap/assert-file-exists

Refactored unittest to check for specific repo files to use assert

Author: Matt Bernier

test/test.js

@@ -216,11 +216,11 @@ describe('Client', function () {
     it('should limit maxSockets', function (done) {
       var expectedSockets = 10
       var maxSocketsClient = new Client(globalRequest, expectedSockets)
-      
+
       nock(TEST_HOST)
         .get('/testMax')
         .reply(200)
-      
+
       // monkey patch the http.request
       var http = require('http')
       var originalRequest = http.request
@@ -241,94 +241,82 @@ describe('Client', function () {
       })
     })
   })
+})
 
-  describe('Project files', function () {
-    it('should have ./Docker file', function (done) {
-      checkFileOrDirectory('Docker')
-      done()
-    })
+describe('nodejs-http-client repo', function() {
+  it('should have ./Dockerfile or docker/Dockerfile', function() {
+    assert(fileExists('Dockerfile') || fileExists('docker/Dockerfile'));
+  });
 
-    it('should have ./docker-compose.yml file', function (done) {
-      checkFileOrDirectory('docker-compose.yml')
-      done()
-    })
+  it('should have ./docker-compose.yml or ./docker/docker-compose.yml file', function() {
+    assert(fileExists('docker-compose.yml') || fileExists('docker/docker-compose.yml'));
+  });
 
-    it('should have ./.env_sample file', function (done) {
-      checkFileOrDirectory('.env_sample')
-      done()
-    })
+  it('should have ./.env_sample file', function() {
+    assert(fileExists('.env_sample'));
+  });
 
-    it('should have ./.gitignore file', function (done) {
-      checkFileOrDirectory('.gitignore')
-      done()
-    })
+  it('should have ./.gitignore file', function() {
+    assert(fileExists('.gitignore'));
+  });
 
-    it('should have ./.travis.yml file', function (done) {
-      checkFileOrDirectory('.travis.yml')
-      done()
-    })
+  it('should have ./.travis.yml file', function() {
+    assert(fileExists('.travis.yml'));
+  });
 
-    it('should have ./.codeclimate.yml file', function (done) {
-      checkFileOrDirectory('.codeclimate.yml')
-      done()
-    })
+  it('should have ./.codeclimate.yml file', function() {
+    assert(fileExists('.codeclimate.yml'));
+  });
 
-    it('should have ./CHANGELOG.md file', function (done) {
-      checkFileOrDirectory('CHANGELOG.md')
-      done()
-    })
+  it('should have ./CHANGELOG.md file', function() {
+    assert(fileExists('CHANGELOG.md'));
+  });
 
-    it('should have ./CODE_OF_CONDUCT.md file', function (done) {
-      checkFileOrDirectory('CODE_OF_CONDUCT.md')
-      done()
-    })
+  it('should have ./CODE_OF_CONDUCT.md file', function() {
+    assert(fileExists('CODE_OF_CONDUCT.md'));
+  });
 
-    it('should have ./CONTRIBUTING.md file', function (done) {
-      checkFileOrDirectory('CONTRIBUTING.md')
-      done()
-    })
+  it('should have ./CONTRIBUTING.md file', function() {
+    assert(fileExists('CONTRIBUTING.md'));
+  });
 
-    it('should have ./.github/ISSUE_TEMPLATE file', function (done) {
-      checkFileOrDirectory('.github/ISSUE_TEMPLATE')
-      done()
-    })
+  it('should have ./.github/ISSUE_TEMPLATE file', function() {
+    assert(fileExists('.github/ISSUE_TEMPLATE'));
+  });
 
-    it('should have ./LICENSE.md file', function (done) {
-      checkFileOrDirectory('LICENSE.md')
-      done()
-    })
+  it('should have ./LICENSE.md file', function() {
+    assert(fileExists('LICENSE.md'));
+  });
 
-    it('should have ./.github/PULL_REQUEST_TEMPLATE file', function (done) {
-      checkFileOrDirectory('.github/PULL_REQUEST_TEMPLATE')
-      done()
-    })
+  it('should have ./.github/PULL_REQUEST_TEMPLATE file', function() {
+    assert(fileExists('.github/PULL_REQUEST_TEMPLATE'));
+  });
 
-    it('should have ./README.md file', function (done) {
-      checkFileOrDirectory('README.md')
-      done()
-    })
-    
-    it('should have ./TROUBLESHOOTING.md file', function (done) {
-      checkFileOrDirectory('TROUBLESHOOTING.md')
-      done()
-    })
-    
-    it('should have ./USAGE.md file', function (done) {
-      checkFileOrDirectory('USAGE.md')
-      done()
-    })
-    
-    it('should have ./USE_CASES.md file', function (done) {
-      checkFileOrDirectory('USE_CASES.md')
-      done()
-    })
+  it('should have ./README.md file', function() {
+    assert(fileExists('README.md'));
+  });
 
-    function checkFileOrDirectory(fileOrDirectory) {  
-      try {
-        fs.statSync(fileOrDirectory);
-      } catch(e) {
-        assert.isNull(e, 'file or folder doesn\'t exist. '+e);
+  it('should have ./TROUBLESHOOTING.md file', function() {
+    assert(fileExists('TROUBLESHOOTING.md'));
+  });
+
+  it('should have ./USAGE.md file', function() {
+    assert(fileExists('USAGE.md'));
+  });
+
+  it('should have ./USE_CASES.md file', function() {
+    assert(fileExists('USE_CASES.md'));
+  });
+
+  function fileExists(filepath) {
+    try {
+      return fs.statSync(filepath).isFile();
+    } catch(e) {
+      if (e.code === 'ENOENT') {
+        console.log('' + filepath + ' doesn\'t exist.');
+        return false;
       }
+      throw e;
     }
-  })
-})
+  }
+});