Skip to content

feat: add option to publish to CI catalog #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Apr 8, 2025

Related to #822

@fgreinacher fgreinacher self-assigned this Apr 8, 2025
@fgreinacher fgreinacher force-pushed the feat/publish-to-catalog branch from cb57c05 to 197c94a Compare April 9, 2025 17:35
@fgreinacher
Copy link
Contributor Author

@JonasSchubert WDYT about doing it like this as a first step?

@fgreinacher fgreinacher changed the base branch from master to next April 10, 2025 05:28
@fgreinacher fgreinacher changed the base branch from next to beta April 28, 2025 13:36
@fgreinacher fgreinacher force-pushed the feat/publish-to-catalog branch from 197c94a to 7f82a48 Compare April 28, 2025 14:13
@xrow
Copy link

xrow commented May 15, 2025

@fgreinacher

I have a wish to this pull. It is possible to autodetect if this a components project by reading the checkbox via api? Of course the config flag shall be present with true false being autodetected if not set. The default value could be maybe null or auto.

image

@fgreinacher fgreinacher force-pushed the feat/publish-to-catalog branch from 7f82a48 to 6280df3 Compare May 15, 2025 08:22
@fgreinacher fgreinacher marked this pull request as ready for review May 15, 2025 08:38
@fgreinacher
Copy link
Contributor Author

With the tests in place I think this is now ready for review.

Can you have a look again @JonasSchubert? 🙇‍♂️

@fgreinacher fgreinacher requested review from JonasSchubert and removed request for JonasSchubert May 15, 2025 08:39
@fgreinacher
Copy link
Contributor Author

@fgreinacher

I have a wish to this pull. It is possible to autodetect if this a components project by reading the checkbox via api? Of course the config flag shall be present with true false being autodetected if not set. The default value could be maybe null or auto.

image

Good idea! I have added it to #851 to track this.

@xrow
Copy link

xrow commented May 16, 2025

@fgreinacher

I did try to verify the changes in this pull, but I was not able to test this successfully. I ended up with error
Response code 422 (Release cannot contain more than 30 components) again.

The errror with debug: https://gitlab.com/xrow-public/ci-tools/-/jobs/10053788956#L517
The config: https://gitlab.com/xrow-public/ci-tools/-/blob/main/.releaserc.json?ref_type=heads
The package.json: https://gitlab.com/xrow-public/ci-tools/-/blob/main/container/semantic-release/package.json?ref_type=heads#L11

It might be something on my end, but I can`t tell what went wrong

Copy link
Contributor

@JonasSchubert JonasSchubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Were not able to run and test it like @xrow.

@fgreinacher
Copy link
Contributor Author

I did try to verify the changes in this pull, but I was not able to test this successfully. I ended up with error
Response code 422 (Release cannot contain more than 30 components) again.

@xrow This is a general limitation of GitLab CI components:

[...], with a maximum of 30 components per project.

@fgreinacher
Copy link
Contributor Author

Thanks all for the feedback! I'm gonna merge this so that we have beta release to test with.

@fgreinacher fgreinacher merged commit 18cf89d into beta May 16, 2025
14 checks passed
@fgreinacher fgreinacher deleted the feat/publish-to-catalog branch May 16, 2025 08:02
Copy link

🎉 This PR is included in version 13.3.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants