-
Notifications
You must be signed in to change notification settings - Fork 88
feat: add option to publish to CI catalog #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb57c05
to
197c94a
Compare
@JonasSchubert WDYT about doing it like this as a first step? |
197c94a
to
7f82a48
Compare
7f82a48
to
6280df3
Compare
With the tests in place I think this is now ready for review. Can you have a look again @JonasSchubert? 🙇♂️ |
Good idea! I have added it to #851 to track this. |
I did try to verify the changes in this pull, but I was not able to test this successfully. I ended up with error The errror with debug: https://gitlab.com/xrow-public/ci-tools/-/jobs/10053788956#L517 It might be something on my end, but I can`t tell what went wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Were not able to run and test it like @xrow.
@xrow This is a general limitation of GitLab CI components:
|
Thanks all for the feedback! I'm gonna merge this so that we have |
🎉 This PR is included in version 13.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Related to #822