Skip to content

fix issue 16 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 9, 2019
Merged

fix issue 16 #17

merged 6 commits into from
Dec 9, 2019

Conversation

achille-roussel
Copy link
Contributor

Fixes #16

This PR fixes an issue where slice types that implement json.Marshaler or encoding.TextMarshaler would output null if the slice value had its zero-value.

@achille-roussel achille-roussel mentioned this pull request Dec 8, 2019
Closed
@achille-roussel
Copy link
Contributor Author

Thanks for the reviews!

@achille-roussel achille-roussel merged commit 4980b2f into master Dec 9, 2019
@achille-roussel achille-roussel deleted the issue16 branch December 9, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelletier pelletier pelletier approved these changes

@jnjackins jnjackins jnjackins approved these changes

@yolken-segment yolken-segment Awaiting requested review from yolken-segment

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

marshaling byte slice ignores json.Marshaler/encoding.TextMarshaler interfaces
3 participants
@achille-roussel @pelletier @jnjackins