BSD fixes for v2.4.5 #3155
Merged
BSD fixes for v2.4.5 #3155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3155 +/- ##
==========================================
- Coverage 85.26% 85.26% -0.01%
==========================================
Files 261 261
Lines 54349 54349
==========================================
- Hits 46339 46338 -1
- Misses 8010 8011 +1
|
gpotter2
reviewed
Mar 28, 2021
| except ImportError as ex: | ||
| warning("Cannot set filter: %s" % ex) | ||
| if NETBSD and filter_attached is False: |
There was a problem hiding this comment.
Wtf. Congratulations for figuring that out 😅
There was a problem hiding this comment.
The crazy part is that Scapy used to work fine on NetBSD...
gpotter2
approved these changes
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Scapy on OpenBSD, FreeBSD and NetBSD. This PR must be merged to address #3100.
The commits are currently applied to 4bec6ee. All tests works fine on NetBSD 9.1, OpenBSD 6.8 (with cryptography 3.3.2), and FreeBSD 12.1.