Add failing test for parent constructor call coverage #965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a86b331 has been commited, a call to an exception's parent constructor will not mark the
$code
argument as covered.I guess adding back
\PhpParser\Node\Scalar
to the list of\SebastianBergmann\CodeCoverage\StaticAnalysis\ExecutableLinesFindingVisitor::isExecutable
would not be a correct fix as it would break what @Slamdunk did in a86b331. I do not know the codebase enough to be able to bring a correct fix, so I start by adding a failing test and would love to have some feedback on how to do it properly.For reference, I ran into this issue when using Infection; see infection/infection#1734.
I rarely contribute to the PHPUnit ecosystem, so I'll take this opportunity to thank the contributors for bringing such a reliable testing framework to PHP. 🤗