Less 3.8 #9
Closed
Less 3.8 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm audit fix output: `fixed 13 of 13 vulnerabilities in 1921 scanned packages`
--strict-math has been deprecated and replaced by --math. See less/less.js#3274
Still haven't updated for the grid breakpoints just yet, though some breakpoint loops have been written in anticipation of those updates.
There are 4 loops in mixins/_grid-framework.less that loop 'til a static number. I'm not aware of any answer for that at the moment, but a plugin could be easily written that could just leverage `each()`.
|
Ha, shit, @calvinjuarez, why didn't I look for this lol. Looks like I did this for no reason today: #12 |
Except one in breakpoints.js: ``` 91:6 warning Variable 'nextBreakpoint' should be initialized on declaration ```
|
@matthew-dean no worries. I've updated this one with your README and package.json updates, and the unquoting of the |
Merged
|
Replaced by #13 |
@matthew-dean Unless you're opposed to #13 for some reason, I think we can simplify by closing #12. Sorry for the confusion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@seanCodes, this PR is 99% of the conversion to Less 3.7.
It's marked "Don't Merge" because there's a discrepancy in how certain
each()loops execute vs SCSS's@each, at the moment (see changes to bootstrap.css in b2837df). I'll investigate that when I get a chance to put together a reduced test case and file a bug w/ Less.I'm opening this PR to claim #7 and because the 3.5+ syntax is exciting! :P