Skip to content

SDK issues with 'set -eu' #597

@andretadeu

Description

@andretadeu

Hi!

At my job I am maintaining several shell scripts created to help software developers to be more productive and I was evaluating the use of SDKMAN to save some work. In order to clean up those scripts, I am using set -eu (and other flags that are not relevant at the moment) to be sure that the scripts have all variables it uses and avoid problems with outdated variables being called in some old scripts that might do something unexpected. However, I am facing some difficulties in using sdk commands because they rely on unbound variables. For example:

sdkman-sdk-list-fail

Now, let us try installing Kotlin:

sdkman-sdk-install-kotlin-fail

PS: I am working on this fix, as this commit in my fork https://github.com/andretadeu/sdkman-cli/commit/fd26629e2135c55facc2d31f60f7b9ad64809151 shows. However I need to ensure that the tests are correct. If I don't set set -eu, all the tests passes, however if I do so, I get some errors and some skipped tests, therefore I am not confident about creating a Pull Request.

PS2: If you have time, could you give an explanation on how these tests works?

Thanks in advance,

André Tadeu de Carvalho

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions