cluster: improve logging of peers row validation #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, when the driver received an invalid system.peers row
it would log a very general warning:
Found an invalid row for peer (127.0.73.5). Ignoring host.
A system.peers row can be invalid for a multitude of reasons and that
warning message did not describe the specific reason for the failure.
Improve the warning message by adding a specific reason why the row
is considered invalid by the driver. The message now also includes
the host_id or the entire row (in case the driver received a row
without even the basic broadcast_rpc).
It might be a bit inelegant to introduce a side effect (logging) to
the _is_valid_peer static method, however the alternative solution seemed
even worse - adding that code to the already big
_refresh_node_list_and_token_map.
Fixes scylladb#303
avelanarius
force-pushed
the
improve-is-valid-peer-logs
branch
from
ba8b4b3 to
3815f53
Compare
Lorak-mmk
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when the driver received an invalid
system.peersrow it would log a very general warning:A
system.peersrow can be invalid for a multitude of reasons and that warning message did not describe the specific reason for the failure.Improve the warning message by adding a specific reason why the row is considered invalid by the driver. The message now also includes the
host_idor the entire row (in case the driver received a row without even the basicbroadcast_rpc).It might be a bit inelegant to introduce a side effect (logging) to the
_is_valid_peerstatic method, however the alternative solution seemed even worse - adding that code to the already big_refresh_node_list_and_token_map.Fixes #303