Skip to content

Commit 3a795b9

Browse files
committed
address review comments
1 parent 3186613 commit 3a795b9

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

rollup/sync_service/sync_service.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,7 @@ func NewSyncService(ctx context.Context, genesisConfig *params.ChainConfig, node
8484
// otherwise there's no way for the node to know if it missed any messages of the V2 queue (as it was not querying it before)
8585
// but continued to query the V1 queue (which after V2 deployment does not contain any messages anymore).
8686
// this is a one-time operation and will not be repeated on subsequent restarts.
87-
if genesisConfig.IsEuclidV2(uint64(time.Now().Unix())) &&
88-
genesisConfig.Scroll.L1Config.L1MessageQueueV2DeploymentBlock > 0 &&
87+
if genesisConfig.Scroll.L1Config.L1MessageQueueV2DeploymentBlock > 0 &&
8988
genesisConfig.Scroll.L1Config.L1MessageQueueV2DeploymentBlock < latestProcessedBlock { // node synced after V2 deployment
9089

9190
// this means the node has never synced V2 messages before -> we need to reset the synced height to re-fetch V2 messages.
@@ -290,7 +289,7 @@ func (s *SyncService) fetchMessages() {
290289

291290
// compare with stored message in database, abort if not equal, ignore if already exists
292291
if msg.QueueIndex < queueIndex {
293-
log.Info("Duplicate queue index in SyncService", "expected", queueIndex, "got", msg.QueueIndex)
292+
log.Warn("Duplicate queue index in SyncService", "expected", queueIndex, "got", msg.QueueIndex)
294293

295294
receivedMsgBytes, err := rlp.EncodeToBytes(msg)
296295
if err != nil {

0 commit comments

Comments
 (0)