add a fixme

colinlyguo · colinlyguo · commit 16757906147d · 2025-03-25T21:20:56.000+08:00
diff --git a/eth/api.go b/eth/api.go
@@ -369,6 +369,8 @@ func generateWitness(blockchain *core.BlockChain, block *types.Block) (*stateles
 		return nil, fmt.Errorf("failed to validate block %d: %w", block.Number(), err)
 	}
 
+	// FIXME: testWitness will fail from time to time, the problem is caused by occasional state root mismatch
+	// after processing the block based on witness. We need to investigate the root cause and fix it.
 	for retries := 0; retries < 5; retries++ {
 		if err = testWitness(blockchain, block, witness); err == nil {
 			return witness, nil

Original file line number	Diff line number	Diff line change
`@@ -369,6 +369,8 @@ func generateWitness(blockchain core.BlockChain, block types.Block) (*stateles`
`369`	`369`	`return nil, fmt.Errorf("failed to validate block %d: %w", block.Number(), err)`
`370`	`370`	`}`
`371`	`371`
	`372`	`+ // FIXME: testWitness will fail from time to time, the problem is caused by occasional state root mismatch`
	`373`	`+ // after processing the block based on witness. We need to investigate the root cause and fix it.`
`372`	`374`	`for retries := 0; retries < 5; retries++ {`
`373`	`375`	`if err = testWitness(blockchain, block, witness); err == nil {`
`374`	`376`	`return witness, nil`