Unable to run scoverage goal(s) in multi-module project with inter-module dependencies

[nvrs]

Hi,

I am trying to execute a scoverage goal directly, e.g. mvn scoverate:integration-report (scoverage is not attached to a specific phase of the lifecycle), but it's impossible to do so on a reactor with modules that have cross-dependencies. The reason seems to be that in the forked process, the reactor dependencies appear to be absent.

On the other hand, if scoverage is attached to maven's lifecycle, tests are always run twice, at least with scalatest, which is very time consuming for us. A possible workaround for us, would be to execute maven clean install -DskipTests=true on the aggregator pom first and then mvn scoverate:integration-report on it. However, this is dangerous to be performed on any environment in general as SNAPSHOT artifacts will end up in maven's cache which could lead to difficult to track bugs etc.

Since i understand that the reactor issue is probably not easy to solve, may i suggest ignoring the flag -DskipTests=true so one could use scoverage attached to the maven lifecycle but without running the tests twice?

[gslowikowski]

Hi. Can you provide test project showing the problem?

[nvrs]

Hi, sure, i ll work on it now and get back to you asap.

[nvrs]

Hi, i have to admit i can't reproduce it on a simple project. So there is either an issue with the maven build of the real project (most probable case), or there's some weird interplay with another plugin, and / or the presence of java code in the mix that's compiled after scala.

Therefore, I ll close this issue and only re-open in case i can reliably reproduce.
Thanks

[nvrs]

I managed to reproduce it using this simple project.

When checking out master, if you don't do a "mvn clean install" you can execute as expected without any errors "mvn scoverage:report" but if you attempt to do "mvn scoverage:integration-report" then the build for module-b will complain about not being able to resolve module-a and module-a:tests snapshot artifacts.

edit: attached mvn output:

`[~/source/scoverage-reactor]>mvn scoverage:integration-report
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] scoverage-reactor
[INFO] module-a
[INFO] module-b
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building scoverage-reactor 1.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] >>> scoverage-maven-plugin:1.3.0:integration-report (default-cli) > [scoverage]verify @ scoverage-reactor >>>
[INFO]
[INFO] --- scoverage-maven-plugin:1.3.0:pre-compile (default-cli) @ scoverage-reactor ---
[INFO] Skipping SCoverage execution for project with packaging type 'pom'
[INFO]
[INFO] --- scala-maven-plugin:3.2.2:add-source (scala-compile-first) @ scoverage-reactor ---
[INFO] Add Source directory: /home/nviorres/source/scoverage-reactor/src/main/scala
[INFO] Add Test Source directory: /home/nviorres/source/scoverage-reactor/src/test/scala
[INFO]
[INFO] --- scala-maven-plugin:3.2.2:compile (scala-compile-first) @ scoverage-reactor ---
[INFO] No sources to compile
[INFO]
[INFO] --- scoverage-maven-plugin:1.3.0:post-compile (default-cli) @ scoverage-reactor ---
[INFO]
[INFO] --- scala-maven-plugin:3.2.2:testCompile (scala-test-compile) @ scoverage-reactor ---
[INFO] No sources to compile
[INFO]
[INFO] <<< scoverage-maven-plugin:1.3.0:integration-report (default-cli) < [scoverage]verify @ scoverage-reactor <<<
[INFO]
[INFO] --- scoverage-maven-plugin:1.3.0:integration-report (default-cli) @ scoverage-reactor ---
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building module-a 1.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] >>> scoverage-maven-plugin:1.3.0:integration-report (default-cli) > [scoverage]verify @ module-a >>>
[INFO]
[INFO] --- scoverage-maven-plugin:1.3.0:pre-compile (default-cli) @ module-a ---
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ module-a ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 0 resource
[INFO]
[INFO] --- scala-maven-plugin:3.2.2:add-source (scala-compile-first) @ module-a ---
[INFO] Add Source directory: /home/nviorres/source/scoverage-reactor/module-a/src/main/scala
[INFO] Add Test Source directory: /home/nviorres/source/scoverage-reactor/module-a/src/test/scala
[INFO]
[INFO] --- scala-maven-plugin:3.2.2:compile (scala-compile-first) @ module-a ---
[INFO] Using incremental compilation
[INFO]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ module-a ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- scoverage-maven-plugin:1.3.0:post-compile (default-cli) @ module-a ---
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ module-a ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /home/nviorres/source/scoverage-reactor/module-a/src/test/resources
[INFO]
[INFO] --- scala-maven-plugin:3.2.2:testCompile (scala-test-compile) @ module-a ---
[INFO] Using incremental compilation
[INFO]
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ module-a ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:2.20:test (default-test) @ module-a ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- scalatest-maven-plugin:1.0:test (test) @ module-a ---
Discovery starting.
Discovery completed in 71 milliseconds.
Run starting. Expected test count is: 1
GreeterSpec:
A Greeter

• should greet persons using their name
  • Given a person named John
  • When the Greeter's greet method is invoked
  • Then the resulting greeting must contain the person's name
    Run completed in 134 milliseconds.
    Total number of tests run: 1
    Suites: completed 2, aborted 0
    Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
    All tests passed.
    [INFO]
    [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ module-a ---
    [INFO] Building jar: /home/nviorres/source/scoverage-reactor/module-a/target/scoverage-module-a-1.1-SNAPSHOT.jar
    [INFO]
    [INFO] --- maven-jar-plugin:2.4:test-jar (default) @ module-a ---
    [INFO] Building jar: /home/nviorres/source/scoverage-reactor/module-a/target/scoverage-module-a-1.1-SNAPSHOT-tests.jar
    [INFO]
    [INFO] --- scalatest-maven-plugin:1.0:test (integration-test) @ module-a ---
    Discovery starting.
    Discovery completed in 27 milliseconds.
    Run starting. Expected test count is: 0
    DiscoverySuite:
    Run completed in 61 milliseconds.
    Total number of tests run: 0
    Suites: completed 1, aborted 0
    Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
    No tests were executed.
    [INFO]
    [INFO] <<< scoverage-maven-plugin:1.3.0:integration-report (default-cli) < [scoverage]verify @ module-a <<<
    [INFO]
    [INFO] --- scoverage-maven-plugin:1.3.0:integration-report (default-cli) @ module-a ---
    [INFO] Reading scoverage instrumentation [/home/nviorres/source/scoverage-reactor/module-a/target/scoverage-data/scoverage.coverage.xml]...
    [INFO] Reading scoverage measurements [/home/nviorres/source/scoverage-reactor/module-a/target/scoverage-data/scoverage.measurements.*]...
    [INFO] Generating coverage reports...
    [INFO] Written Cobertura XML report [/home/nviorres/source/scoverage-reactor/module-a/target/cobertura.xml]
    [INFO] Written XML coverage report [/home/nviorres/source/scoverage-reactor/module-a/target/scoverage.xml]
    [INFO] Written HTML coverage report [/home/nviorres/source/scoverage-reactor/module-a/target/site/scoverage/index.html]
    [INFO] Statement coverage.: 100.00%
    [INFO] Branch coverage....: 100.00%
    [INFO] Coverage reports completed.
    [INFO]
    [INFO] ------------------------------------------------------------------------
    [INFO] Building module-b 1.1-SNAPSHOT
    [INFO] ------------------------------------------------------------------------
    [INFO]
    [INFO] >>> scoverage-maven-plugin:1.3.0:integration-report (default-cli) > [scoverage]verify @ module-b >>>
    [INFO] ------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO]
    [INFO] scoverage-reactor .................................. SUCCESS [ 0.618 s]
    [INFO] module-a ........................................... SUCCESS [ 2.309 s]
    [INFO] module-b ........................................... FAILURE [ 0.013 s]
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD FAILURE
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 3.351 s
    [INFO] Finished at: 2017-08-29T16:12:13+03:00
    [INFO] Final Memory: 19M/344M
    [INFO] ------------------------------------------------------------------------
    [ERROR] Failed to execute goal on project module-b: Could not resolve dependencies for project nvrs:module-b:jar:1.1-SNAPSHOT: The following artifacts could not be resolved: nvrs:module-a:jar:1.1-SNAPSHOT, nvrs:module-a:jar:tests:1.1-SNAPSHOT: Failure to find nvrs:module-a:jar:1.1-SNAPSHOT in https://nexus.*.com/nexus/content/groups/public was cached in the local repository, resolution will not be reattempted until the update interval of nexus has elapsed or updates are forced -> [Help 1]
    [ERROR]
    [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
    [ERROR] Re-run Maven using the -X switch to enable full debug logging.
    [ERROR]
    [ERROR] For more information about the errors and possible solutions, please read the following articles:
    [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
    [ERROR]
    [ERROR] After correcting the problems, you can resume the build with the command
    [ERROR] mvn -rf :module-b
    `

[gslowikowski]

module-b depends on module-a:${project.version}:test-jar.

When executing Scoverage lifecycle scoverage- prefix is being added to finalName property (module-a becomes scoverage-module-a) to avoid overwriting regular artifacts with instrumented ones. Of course tests are never instrumented, but the mechanism is general and changes the name of tests jar too.

As a result, when building module-b, Maven cannot find module-a:${project.version}:test-jar dependency because there is only scoverage-module-a:${project.version}:test-jar.

I must think, if and how this can be fixed.

[nvrs]

I see. What the above doesn't explain though is why scoverage:report mojo runs without any issues whereas :integration-report won't.

In any case, if you need any help i could try and have a look.

[gslowikowski]

Hi @nvrs. I'm returning to old open issues.

Many users are asking for a JaCoCo-like mode, where Scoverage does not fork a life cycle. This will be dangerous because users can accidentally deploy instrumented artifacts, but I will work on it.

For now, for your case, the best solution (without installing artifacts first) is to call:

mvn package scoverage:integration-report

module-a's jar and test-jar dependencies are checked by Maven before Scoverage plugin code is executed and because module-a wasn't built without Scoverage, Maven cannot find required artifacts and fails. In forked Scoverage life cycle Scoverage plugin switches to instrumented version of module-a dependency, but it is done later, when Maven gets all the required dependencies and starts execution of this forked life cycle.

I'm closing this issue. Reopen it if you want to discuss this case further.

[gslowikowski]

Check my comment please.