Enabled CI on Windows and applied some fixes #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
changed the title
|
Hm, looks like on Windows, tests are flaky. Same branch was built without errors on my user account: https://github.com/lefou/scalac-scoverage-plugin/actions/runs/1238249042 Maybe, the concurrent measurement file writer logic isn't as robust on Windows as expected. |
ckipp01
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Thanks a lot for this @lefou. Historically I don't think there has been a lot of focus on Windows and for myself now I don't have a windows machine. I think this is a good change and I can try to look more into what might be happening with the flaky windows test and the errors we are seeing.
ckipp01
pushed a commit
that referenced
this pull request
Sep 23, 2021
* CI: also build on Windows * Added Windows lookup path for coursier * Consider windows line terminators too * More line ending stuff * Some comments * .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.