Correct build dependencies. #325
Conversation
| @@ -70,8 +70,7 @@ lazy val runtime = CrossProject( | |||
| crossTarget := target.value / s"scala-${scalaVersion.value}", | |||
| crossVersion := CrossVersion.full, | |||
| libraryDependencies ++= Seq( | |||
| "org.scalatest" %%% "scalatest" % scalatestVersion % Test, | |||
| "org.scala-lang" % "scala-compiler" % scalaVersion.value % Compile | |||
There was a problem hiding this comment.
@lefou you were totally correct... this doesn't need to be a dependency for the runtime. If you look back at the commits it seems to have slipped in when I refactored the build definition.
There was a problem hiding this comment.
What I wonder is, whether we can avoid the CrossVersion.full for the runtime.
There was a problem hiding this comment.
So from digging further in, from what I can tell, no this doesn't need a full cross version. I've gone ahead and tested this locally and also with the sbt plugin to verify. I've gone ahead and removed the CrossVersion.full on the runtime and also then could remove the hacky thing we were doing to name the scalaJS artifact correct as well since it's now done correctly automatically.
There was a problem hiding this comment.
You should be able to give this a try now wtih 1.4.5+1-775fcaca-SNAPSHOT. Report back if something seems awry. I'd be good to get this more widely tested before a release.
This makes a few small changes: 1. I'm pretty sure the scala-compiler for the actual plugin can just have a Provided scope. I don't believe we actually need to package it up seeing that it should always be there. 2. Secondly, I mistakenly added the scala-compiler as a dependency to the runtime artifact when it indeed should not be. When I refactored the build, it came along, and should have not. If you look back you'll notice that it wasn't in 1.4.1 3. When the change was made to start doing a full cross publish in this commit: ac3db32 it was added for both the compiler plugin and the actual runtime. Looking through things and testing locally with the sbt plugin, I don't see a reason why the runtime needs to actually be crossed fully like the actual plugin. This removes the crossVersion full from the runtime.
This makes a few small changes:
have a Provided configuration. I don't believe we actually need to package it
up seeing that it should always be there.
the runtime artifact when it indeed should not be. When I refactored
the build, it came along, and should have not. If you look back
you'll notice that it wasn't in 1.4.1
commit: ac3db32
it was added for both the compiler plugin and the actual runtime.
Looking through things and testing locally with the sbt plugin, I
don't see a reason why the runtime needs to actually be crossed fully
like the actual plugin. This removes the crossVersion full from the
runtime.